Redux Test Suite Expansion

[dternyak]

No description provided.

[bfillmer]

General coverage improvements or....?

[dternyak]

Yes. I'm not sure if we need to formalize a specific number, but it should be significantly higher than it is today (with many reducers / sagas completely untested).

…

On Sun, Aug 27, 2017 at 6:26 AM Bryan Fillmer ***@***.***> wrote: General coverage improvements or....? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <MyEtherWallet/MyEtherWallet#84 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHf02Y7rWiCsrgBZH-DFW1mNGrtt-BQtks5scVJsgaJpZM4OjG_q> .

[bfillmer]

WIP @ https://github.com/MyEtherWallet/MyEtherWallet/tree/redux-test-improvements

@dternyak One improvement to consider is leveraging snapshot testing for these. Effectively replace defining expected results with snapshots that are auto-generated. Example: https://github.com/bfillmer/todo-and-tonic/blob/master/src/state/reducers/todos.spec.js

When iterating on the test the first time through you update the snapshot until you see the state you expect, then leave it. In the future if any code changes would affect the state shape the snapshots won't match up and Jest will let you know. If it's an expected change you can simply update the snapshot, if not then you know to start digging into the issue.

[dternyak]

I've heard good things about snapshot testing as well. Seems like a good approach for getting an initial layer of tests going 👍