Build fixes #914
Closed
Build fixes #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydumper itself doesn't use OpenSSL, libmysqlclient does. Checking to see if OpenSSL is installed on the machine compiling mydumper does not check if libmysqlclient was built with OpenSSL. libmysqlclient could for example have been build with OpenSSL statically compiled. Also MySQL 8.0 doesn't have this as an option and MariaDB Connector/C can compile with other SSL libraries. If the intention is to check of libmysqlclient was built with OpenSSL then a symbol check should be made instead.
|
@LinuxJedi can you fix the CircleCI checks first? |
Any idea how? It is just telling me there is a missing config file? I've never used CircleCI before. |
|
CI seems broken here, I'll closed and reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a whole bunch of things regarding the build process, including:
make distto work with git instead of bzrOpenSSL check has been removed, mydumper itself doesn't use OpenSSL, libmysqlclient does. Checking to see if OpenSSL is installed on the machine compiling mydumper does not check if libmysqlclient was built with OpenSSL. libmysqlclient could for example have been build with OpenSSL statically compiled. Also MySQL 8.0 doesn't have this as an option and MariaDB Connector/C can compile with other SSL libraries.
If the intention is to check of libmysqlclient < 8.0 was built with OpenSSL then a symbol or build test check should be made instead.
Also fixes Andrew's email address / affiliation.