Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASAN and TSAN sanitizers #917

Merged
merged 1 commit into from Nov 24, 2022
Merged

Conversation

LinuxJedi
Copy link
Collaborator

New options for ASAN and TSAN sanitizers, it is recommended these are added to the CI process when issues they find are fixed.

ASAN finds leaks, similar to valgrind but is compiled in and much faster. TSAN finds thread issues such as race conditions.

You can enable them using -DWITH_ASAN or -DWITH_TSAN. They cannot be used at the same time.

New options for ASAN and TSAN sanitizers, it is recommended these are
added to the CI process when issues they find are fixed.

ASAN finds leaks, similar to valgrind but is compiled in and much
faster. TSAN finds thread issues such as race conditions.

You can enable them using -DWITH_ASAN or -DWITH_TSAN. They cannot be
used at the same time.
@davidducos davidducos added this to the Release 0.13.1-1 milestone Nov 24, 2022
@davidducos davidducos merged commit e0b8ad0 into mydumper:master Nov 24, 2022
@davidducos
Copy link
Member

Hi @LinuxJedi, This failed for Bionic, Xenial and EL7.

@LinuxJedi
Copy link
Collaborator Author

@davidducos you mean when ASAN or TSAN is enabled? Yes, there are issues that need resolving. This is just the tools to detect them.

If you mean this breaks the build, do you have a link or more info? It worked on those platforms on my servers.

@davidducos
Copy link
Member

@LinuxJedi
I rebuild my xenial VM and I got the same issue, reviewing just a bit about it I found that add_link_options was introduced in newer version of CMake that xenial doesn't have. So, in order to support old version too, I will create a PR.
About the building process, I prefer to start working over CircleCI instead of sharing mine (#835) as I think that it will be more valuable.

@LinuxJedi
Copy link
Collaborator Author

LinuxJedi commented Nov 24, 2022

Ah! My bad, I already had an updated CMake on my machines due to another project I work on.

@davidducos
Copy link
Member

No worries! make sense now! I will be adding the PR later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants