Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --debug mode #929

Merged
merged 3 commits into from Jan 17, 2023
Merged

Add --debug mode #929

merged 3 commits into from Jan 17, 2023

Conversation

LinuxJedi
Copy link
Collaborator

This patch does a few things:

  • Add --debug to enable debugging output on STDOUT, this also sets --verbose to 3 automatically.
  • Remove duplicate bit setting in set_verbose.c.
  • Disable debugging output for the log writer if --debug was not specified.

This patch does a few things:

* Add `--debug` to enable debugging output on STDOUT, this also sets
  `--verbose` to `3` automatically.
* Remove duplicate bit setting in `set_verbose.c`.
* Disable debugging output for the log writer if `--debug` was not
  specified.
@LinuxJedi
Copy link
Collaborator Author

@davidducos Circle CI appears to have failed due to a network issue. I don't appear to have access to restart the run. Are you able to do it?

@davidducos
Copy link
Member

@LinuxJedi It has failed again... :(

@davidducos davidducos added this to the Release 0.13.3-1 milestone Dec 2, 2022
@LinuxJedi
Copy link
Collaborator Author

LinuxJedi commented Dec 2, 2022

@LinuxJedi It has failed again... :(

This is the good kind of failure, the one where I neglected to check that an API I used was only 18 months old.

@davidducos
Copy link
Member

@LinuxJedi, yeah... it happens... I will be adding testings on CircleCI for all OS that we do releases to found this kind of errors. For sure, I will be adding more testings to avoid to release with bugs...

Disable the `--debug` version for old glib versions. Users will need to
use the environment variable `G_MESSAGES_DEBUG=all` instead for older
versions of glib.
@LinuxJedi
Copy link
Collaborator Author

Fixed this by having this option only show up if you are using glib >= 2.72. Before this you'll need to use the environment variable G_MESSAGES_DEBUG=all (same as before this patch).

@davidducos
Copy link
Member

Thanks @LinuxJedi, I will be merging this after we fix some issues on v0.13.1 series. For sure, this will be merged by January.

davidducos
davidducos previously approved these changes Dec 2, 2022
@davidducos davidducos merged commit b2f84d2 into mydumper:master Jan 17, 2023
0 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants