Do not set UNIQUE_CHECKS=0 for MariaDB #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`UNIQUE_CHECKS=0` sets MariaDB into a special mode that adds table level locks for InnoDB. This accelerates single-threaded insert performance, but makes multi-threaded into one table much slower.
|
Looking into CI failures... |
Also switch out table info query which will assist with sequences and system version tables.
|
Should be good now, I missed a bit when cherry-picking the MariaDB ident stuff from another branch :) |
|
Hi @LinuxJedi, I removed the specific lines related to mariadb and SET SESSION. I think that the other changes are needed! merging now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNIQUE_CHECKS=0sets MariaDB into a special mode that adds table levellocks for InnoDB. This accelerates single-threaded insert performance,
but makes multi-threaded into one table much slower.
This also adds a patch to fix the MariaDB type and version check.
Fixes #987