Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GSoC fixed-point compiler #228

Merged
merged 81 commits into from Jan 10, 2018

Conversation

@qrqiuren
Copy link

commented Jun 19, 2017

This is the pull request for the implementation of the fixed-point compiler in GSoC 2017.

@cfelton
Copy link
Member

left a comment

qrqiuren, you need to remove majority of the alignment checks and implement auto alignment and generate a set of tests for these.

@@ -0,0 +1,174 @@
# This file is part of the myhdl library, a Python package for using

This comment has been minimized.

Copy link
@cfelton

cfelton Jul 8, 2017

Member

The _resize module needs to be removed and its functionality automatically handled by the fixbv operators.

from myhdl import fixbv
from myhdl._fixbv import FixedPointFormat as fpf

def test_fpf_inst():

This comment has been minimized.

Copy link
@cfelton

cfelton Jul 8, 2017

Member

With this code, we should also make it PEP8 compliant, this code should be updated. I have made some of these small changes that I will post to your branch.

v = val._val
else:
v = val
# @todo: convert negative keys to the correct bit index

This comment has been minimized.

Copy link
@cfelton

cfelton Jul 8, 2017

Member

Need to add the round and alignment functions here, the majority of the work for this project is the automatic alignment and sizing.

#if isinstance(other, _Signal):
# other = other._val
if isinstance(other, fixbv):
assert self._W._fwl == other._W._fwl, \

This comment has been minimized.

Copy link
@cfelton

cfelton Jul 8, 2017

Member

The assert needs to be removed and the automatic alignment needs to occur.

#if isinstance(other, _Signal):
# other = other._val
if isinstance(other, fixbv):
assert self._W._fwl == other._W._fwl, \

This comment has been minimized.

Copy link
@cfelton

cfelton Jul 8, 2017

Member

Need to remove the assert and implement the automatic alignment.

if isinstance(other, _Signal):
other = other._val
if isinstance(other, fixbv):
assert self._W._fwl == other._W._fwl, \

This comment has been minimized.

Copy link
@cfelton

cfelton Jul 8, 2017

Member

Remove assert and implement auto alignment

qrqiuren added some commits Aug 1, 2017

@jck jck merged commit 50ebc9a into myhdl:gsoc Jan 10, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.