New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix integer ordinal #49

Merged
merged 3 commits into from Jul 29, 2015

Conversation

Projects
None yet
2 participants
@joeyates
Contributor

joeyates commented Jul 29, 2015

ordinal/1 was returning incorrect values for 11, 12 and 13

joeyates added some commits Jul 29, 2015

Use mathematical, not string, operators
* it seems more logical to do mathematical operations on numbers.
* it's faster.
@druzn3k

This comment has been minimized.

Show comment
Hide comment
@druzn3k

druzn3k Jul 29, 2015

Collaborator

Why :erlang.abs and :erlang.div when there are abs and div in Elixir? Anyway, thank you @joeyates

Collaborator

druzn3k commented Jul 29, 2015

Why :erlang.abs and :erlang.div when there are abs and div in Elixir? Anyway, thank you @joeyates

druzn3k added a commit that referenced this pull request Jul 29, 2015

@druzn3k druzn3k merged commit 106da33 into mykewould:master Jul 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment