New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Recursive References #44

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Levirclark
Copy link

Levirclark commented Feb 3, 2019

Users have been mentioning that recursive references are still a problem.
Setting cell a1 to the value '=A1' will crash the application.
This fixes that, by scanning for recursive references prior to attempting a render.

Fixed Recursive References
Users have been mentioning that recursive references are still a problem.
Setting cell a1 to the value '=A1' will crash the application.
This fixes that, by scanning for recursive references prior to attempting a render.
@sain2424

This comment has been minimized.

Copy link
Contributor

sain2424 commented Feb 4, 2019

This already works. Demo isn't updated.

@Levirclark

This comment has been minimized.

Copy link
Author

Levirclark commented Feb 4, 2019

It's not working if you follow the dev process

git clone https://github.com/myliang/x-spreadsheet.git
cd x-spreadsheet
npm install
npm run dev

Should it be working on local dev servers?

@Levirclark Levirclark closed this Feb 8, 2019

@Levirclark Levirclark reopened this Feb 8, 2019

@myliang myliang closed this in 8bd8494 Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment