Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorPicker HCY: Pick H, C, or Y from canvas #836

Merged
merged 1 commit into from Nov 4, 2017

Conversation

@briend
Copy link
Member

commented Jul 12, 2017

Hold down control, shift, or alt plus 'r' to modify brush color in the H, C, or Y dimensions, respectively.

  • Colors picked in HCY
  • Avoid reset to Red for achromatic picks
  • Make color space a preference? HCY really is great, IMO
  • Better keyboard shortcuts? Let user decide
    Discussion here:
    #835
    closes #835
    closes #838

@briend briend closed this Jul 12, 2017

@briend briend reopened this Jul 12, 2017

@briend briend changed the title ColorPicker HCY: Allow grabbing H, C, or Y from canvas ColorPicker HCY: Allow grabbing H, C, or Y from canvas [WIP] Jul 12, 2017

@briend briend force-pushed the briend:pickHCY branch from 8ae8030 to 8d819a5 Jul 13, 2017

@briend briend force-pushed the briend:pickHCY branch from 2b3aa07 to 8975211 Jul 21, 2017

<property name="icon-name">mypaint-pick-color-h-symbolic</property>
<property name="group">SymmetryEditMode</property>
<property name="value">11</property>
<!-- NO TOOLTIP OR LABEL. -->

This comment has been minimized.

Copy link
@briend

briend Jul 23, 2017

Author Member

Should every action have a menu item? Seems like 4 colorpick modes in the menu is overkill but not sure

@briend briend force-pushed the briend:pickHCY branch from 587153a to 3a264ab Jul 27, 2017

@briend

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2017

The only problem now is that if you release the modifier before the "r" key, you might trigger a normal pick mode if the cursor was moving. Plus, this normal pick mode popup gets "stuck" until you press "r" again. This might just be the caveat with using the modifier keys and one "r" key, and it is best to pick a different key map. Maybe leave default keys blank?

@briend briend added the enhancement label Jul 28, 2017

@briend briend changed the title ColorPicker HCY: Allow grabbing H, C, or Y from canvas [WIP] ColorPicker HCY: Pick H, C, or Y from canvas Aug 18, 2017

@briend briend requested a review from achadwick Sep 28, 2017

@briend briend force-pushed the briend:pickHCY branch from 3a264ab to 5ae1d95 Sep 30, 2017

ColorPicker HCY: Allow grabbing H, C, or Y from canvas
Hold down shift, control, or alt plus 'r' to modify brush color
Also preserves hue for all pick modes when picking achromatic colors

@briend briend force-pushed the briend:pickHCY branch from 5ae1d95 to ac16c80 Nov 4, 2017

@briend briend merged commit 59977ec into mypaint:master Nov 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/tea the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@briend briend deleted the briend:pickHCY branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.