hotfix: show orders that are made with 4.1.7 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in old orders the code tries to call WCMPBE_ShipmentOptionsFromOrderAdapter and WCMPBE_ShipmentOptionsFromOrderAdapter but the name has changed.
EdieLemoine
requested changes
May 20, 2021
| @@ -25,7 +25,7 @@ public function __construct(?AbstractDeliveryOptionsAdapter $originAdapter, arra | |||
| $this->date = $inputData['date'] ?? $adapterDate; | |||
| $this->deliveryType = $inputData['delivery_type'] ?? $adapterDeliveryType; | |||
| $this->packageType = $inputData['package_type'] ?? $adapterPackageType; | |||
| $this->shipmentOptions = new WCMPBE_ShipmentOptionsFromOrderAdapter($originAdapter, $inputData); | |||
| $this->shipmentOptions = new WCMP_ShipmentOptionsFromOrderAdapter($originAdapter, $inputData); | |||
There was a problem hiding this comment.
new self kan ook, vind ik wel beter, leest makkelijker omdat je meteen begrijpt dat het om de huidige class gaat en het zou ook een paar van deze changes overbodig gemaakt hebben
joerivanveen
approved these changes
May 20, 2021
EdieLemoine
approved these changes
May 20, 2021
RichardPerdaan
deleted the
MY-28624-rename-WCMPBE_DeliveryOptionsFromOrderAdapter-name
branch
RichardPerdaan
restored the
MY-28624-rename-WCMPBE_DeliveryOptionsFromOrderAdapter-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In old orders the code tries to call WCMPBE_ShipmentOptionsFromOrderAdapter and WCMPBE_ShipmentOptionsFromOrderAdapter but the name has changed.