Clean up custom code in `Vagrantfile` #47

Open
patcon opened this Issue Sep 16, 2012 · 5 comments

Comments

Projects
None yet
2 participants
Contributor

patcon commented Sep 16, 2012

Code Climate only evaluates proper modules and classes. The current code sucks at that. Needs to be cleaned up and moved into lib/ dir.


Original post

I'd like myself and everyone else to confront how bad my ruby can be, in the hopes that it will shame me into getting better.

Code Climate is a little like Travis CI, but for grading your coding style for each file via static analysis, and telling you when code gets better or worse with each commit

Just signed up: https://codeclimate.com/github/myplanetdigital/ariadne

Will add badge later

Contributor

patcon commented Sep 16, 2012

Rats. Apparently it only scans app/ and lib/ dirs for files to grade, so unless I convert this into a gem, no dice.

Hey @brynary, I came across you being just generally awesome in this thread: ryanb/cancan#676

Any chance that codeclimate might be getting some like .travis.yml to customize things like setting file patterns?

patcon added a commit that referenced this issue Sep 16, 2012

Added badges to README (Code Climate [GH-47], Travis CI, Coderwall en…
…dorsements). Added blank travis file [GH-48]. Added contributor section to README.

brynary commented Sep 16, 2012

Hello!

Code Climate used to only do app/ and lib/, but now tries to find all Ruby files it doesn't think are config files or tests. The code must be defined inside classes or modules, however.

Does this get you what you need?

-Bryan

Contributor

patcon commented Sep 16, 2012

That's totally useful! Thanks man! Will investigate why it's not picking up the very little code that meets that criteria :)

Contributor

patcon commented Sep 18, 2012

TODO on this might as well involve removing all the hacky stuff in Vagrantfile, making it pretty, and putting it in lib/ (even if CodeClimate doesn't explicitly need it)

Contributor

patcon commented Sep 20, 2012

Sahweet. It's picking stuff up now, so more incentive to do this :)
https://codeclimate.com/github/myplanetdigital/ariadne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment