Skip to content

Use Github action arm runner for aarch64 builds#89

Merged
hauntsaninja merged 2 commits into
mypyc:masterfrom
cdce8p-forks:github-arm-runners
Jan 17, 2025
Merged

Use Github action arm runner for aarch64 builds#89
hauntsaninja merged 2 commits into
mypyc:masterfrom
cdce8p-forks:github-arm-runners

Conversation

@cdce8p
Copy link
Copy Markdown
Contributor

@cdce8p cdce8p commented Jan 16, 2025

@cdce8p cdce8p force-pushed the github-arm-runners branch from bea3e6b to 1302f1d Compare January 16, 2025 18:29
@cdce8p cdce8p force-pushed the github-arm-runners branch from 525ba11 to 87ed858 Compare January 16, 2025 20:06
Copy link
Copy Markdown
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh exciting! Thanks for being so on top of this!

Comment thread .github/workflows/build.yml Outdated
echo "include=$MATRIX" | tee -a $GITHUB_OUTPUT
env:
CIBW_ARCHS_LINUX: x86_64 aarch64
CIBW_ARCHS_LINUX: x86_64
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we remove this from here and move --archs x86_64 into the cibuildwheel command above?

@hauntsaninja
Copy link
Copy Markdown
Collaborator

Sick, looks like the tests run >2x faster on these arm runners than they do on the x86 runners. Maybe we should switch mypy CI to run on the arm runners too...

@hauntsaninja hauntsaninja merged commit ec06cea into mypyc:master Jan 17, 2025
@cdce8p cdce8p deleted the github-arm-runners branch January 17, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants