Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourceMappingURL directive interferes with source mapping when bundling #2

Closed
davidmason opened this issue May 18, 2014 · 2 comments
Closed

Comments

@davidmason
Copy link

When I use webpack to bundle commonjs modules, the source mapping directive from performance-now.js is brought in and interferes with the browser's ability to pick up the source map for the bundle.

This is a transient dependency for my module, so I am not able to use a coffeescript loader to bring in performance-now.coffee directly. Is the source map useful other than during development? If not, the directive would ideally not appear in the published javascript.

This is what I end up with in my bundle:

    ...
    /*
    //@ sourceMappingURL=performance-now.map
    */

    /* WEBPACK VAR INJECTION */}.call(exports, __webpack_require__(19)))

/***/ }
/******/ ])
/*
//@ sourceMappingURL=bundle.js.map
*/
@sokra
Copy link

sokra commented May 24, 2014

This is an bundler issue, not an issue of performance-now. It has been fixed for webpack...

@myrne
Copy link
Owner

myrne commented May 24, 2014

@davidmason I'm closing this. IMO bundlers should be able to handle source map comments, and as I understand it, there's now a way to make it work in webpack.

@myrne myrne closed this as completed May 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants