Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Skip patron on 1.8.7.

The HTTP requests timeout (presumably due to switching to a threaded server instead of a forked one) on 1.8.7. We can safely skip them as there isn't any patron-specific logic in VCR.
  • Loading branch information...
commit a20ac40bc882487ac44853f731bd9a3ccd18a31b 1 parent 1b4703d
@myronmarston authored
View
5 features/support/http_lib_filters.rb
@@ -5,9 +5,8 @@ def cell_values
end
end
-if RUBY_VERSION == '1.9.2'
- # For some reason, the local sinatra server locks up and never exits
- # when using patron on 1.9.2, even though it exits fine during the specs.
+if RUBY_VERSION == '1.8.7'
+ # We get timeouts on 1.8.7 w/ Patron for some reason.
UNSUPPORTED_HTTP_LIBS = %w[ patron ]
elsif defined?(RUBY_ENGINE) && RUBY_ENGINE == 'rbx'
# Patron is freezing up the cukes (as it does on 1.9.2)
View
4 spec/vcr/library_hooks/webmock_spec.rb
@@ -69,7 +69,9 @@ def run_after_request_callback
end
end
- %w[net/http patron httpclient em-http-request curb typhoeus excon].each do |lib|
+ http_libs = %w[net/http patron httpclient em-http-request curb typhoeus excon]
+ http_libs.delete('patron') if RUBY_VERSION == '1.8.7'
+ http_libs.each do |lib|
other = []
other << :status_message_not_exposed if lib == 'excon'
it_behaves_like 'a hook into an HTTP library', :webmock, lib, *other do
View
4 spec/vcr/middleware/faraday_spec.rb
@@ -2,7 +2,9 @@
require 'vcr/library_hooks/faraday'
describe VCR::Middleware::Faraday do
- %w[ typhoeus net_http patron ].each do |lib|
+ http_libs = %w[ typhoeus net_http patron ]
+ http_libs.delete('patron') if RUBY_VERSION == '1.8.7'
+ http_libs.each do |lib|
it_behaves_like 'a hook into an HTTP library', :faraday, "faraday (w/ #{lib})",
:status_message_not_exposed,
:does_not_support_rotating_responses,
Please sign in to comment.
Something went wrong with that request. Please try again.