Permalink
Browse files

Fix failing specs.

- The debug_logger note wasn't included in the error message when there is no cassette.
- The new Faraday release includes my fix for the handling of an empty response by its Net::HTTP adapter.
  • Loading branch information...
1 parent b93fdcd commit eb91c8a42320ed3249da96259483b6f5999184a2 @myronmarston committed Aug 15, 2012
Showing with 2 additions and 2 deletions.
  1. +1 −1 lib/vcr/errors.rb
  2. +1 −1 spec/support/shared_example_groups/hook_into_http_library.rb
View
@@ -212,7 +212,7 @@ def suggestions
end
def no_cassette_suggestions
- [:use_a_cassette, :allow_http_connections_when_no_cassette, :ignore_request].map do |key|
+ [:try_debug_logger, :use_a_cassette, :allow_http_connections_when_no_cassette, :ignore_request].map do |key|
suggestion_for(key)
end
end
@@ -56,7 +56,7 @@ def self.test_record_and_playback(description, query)
test_record_and_playback "with a complex escaped query param", "q=#{CGI.escape("A&(! 234k !@ kasdj232\#$ kjw35")}"
it 'plays back an empty body response exactly as it was recorded (e.g. nil vs empty string)' do
- pending "awaiting an external fix", :if => library.gsub('_', '/').include?('net/http') && library_hook_name != :webmock do
+ pending "awaiting an external fix", :if => (library_hook_name == :fakeweb) do
get_body = lambda do
VCR.use_cassette('empty_body', :record => :once) do
get_body_object make_http_request(:get, "http://localhost:#{VCR::SinatraApp.port}/204")

0 comments on commit eb91c8a

Please sign in to comment.