Skip to content
Commits on Sep 8, 2012
  1. 2.2.5 release.

    committed Sep 7, 2012
Commits on Sep 7, 2012
  1. Update changelog.

    committed Sep 7, 2012
  2. Fix excon hook so it works on 1.8.7.

    committed Sep 6, 2012
    My use of splat args wasn't able to parse on 1.8.7.
    
    Thanks to @jacobkg for pointing this out.
  3. @Jacobkg

    Collapse cucumber scenario outline feature into cucumber feature. Ref…

    Jacobkg committed Sep 6, 2012
    …actor cucumber.rb naming code. Add spec.
  4. @Jacobkg

    Merge pull request #186 from bendyworks/fix_scenario_outline

    Jacobkg committed Sep 6, 2012
    Fix scenario outline
Commits on Sep 5, 2012
  1. Fix excon compatibility.

    committed Sep 4, 2012
    We need to remove the undesirable options from the connection's instance variable params, and not simply from the params that are passed to #request.
    
    I suspect that there might have been edge case bugs before now with the old
    logic.
    
    Fixes #193.
Commits on Aug 18, 2012
Commits on Aug 15, 2012
  1. Fix failing specs.

    committed Aug 15, 2012
    - The debug_logger note wasn't included in the error message when there is no cassette.
    - The new Faraday release includes my fix for the handling of an empty response by its Net::HTTP adapter.
  2. @Jacobkg

    Fix for #188. Add mention of debug logging configuration option to un…

    Jacobkg committed with Aug 15, 2012
    …handled request error message. Also added it to the no_cassette.feature.
Commits on Aug 13, 2012
  1. Allow jruby 18 failure.

    committed Aug 12, 2012
    I'm getting a weird error from Jruby:
    
    $ script/ci.sh
    81CachingCallSite.java:311:in `cacheAndCall': java.lang.NullPointerException
    82	from CachingCallSite.java:169:in `call'
    83	from /home/vagrant/.rvm/rubies/jruby-1.6.7.2/lib/ruby/site_ruby/1.8/rubygems/version.rb:279:in `__file__'
    84	from /home/vagrant/.rvm/rubies/jruby-1.6.7.2/lib/ruby/site_ruby/1.8/rubygems/version.rb:-1:in `__file__'
    85	from JittedMethod.java:127:in `call'
    86	from DefaultMethod.java:183:in `call'
    87	from CachingCallSite.java:133:in `call'
    88	from CallNoArgNode.java:63:in `interpret'
    89	from LocalAsgnNode.java:123:in `interpret'
    90	from NewlineNode.java:104:in `interpret'
    91	from BlockNode.java:71:in `interpret'
    92	from ASTInterpreter.java:74:in `INTERPRET_METHOD'
    93	from InterpretedMethod.java:190:in `call'
    94	from DefaultMethod.java:199:in `call'
    95	from RuntimeHelpers.java:2622:in `invokedynamic'
    96	from RubyComparable.java:149:in `op_ge'
    97	from RubyComparable$s$1$0$op_ge.gen:65535:in `call'
    98	from CachingCallSite.java:312:in `cacheAndCall'
    99	from CachingCallSite.java:169:in `call'
    100	from GeCallSite.java:37:in `call'
    101	from CallOneArgNode.java:57:in `interpret'
    102	from IfNode.java:111:in `interpret'
    103	from NewlineNode.java:104:in `interpret'
    104	from BlockNode.java:71:in `interpret'
    105	from IfNode.java:117:in `interpret'
    106	from NewlineNode.java:104:in `interpret'
    107	from BlockNode.java:71:in `interpret'
    108	from ASTInterpreter.java:111:in `INTERPRET_BLOCK'
    109	from InterpretedBlock.java:374:in `evalBlockBody'
    110	from InterpretedBlock.java:347:in `yield'
    111	from InterpretedBlock.java:304:in `yield'
    112	from Block.java:130:in `yield'
    113	from YieldNode.java:119:in `interpret'
    114	from IfNode.java:117:in `interpret'
    115	from NewlineNode.java:104:in `interpret'
    116	from BlockNode.java:71:in `interpret'
    117	from ASTInterpreter.java:74:in `INTERPRET_METHOD'
    118	from InterpretedMethod.java:169:in `call'
    119	from DefaultMethod.java:191:in `call'
    120	from CachingCallSite.java:142:in `callBlock'
    121	from CachingCallSite.java:148:in `call'
    122	from RubyClass.java:822:in `newInstance'
    123	from RubyClass$i$newInstance.gen:65535:in `call'
    124	from CachingCallSite.java:302:in `cacheAndCall'
    125	from CachingCallSite.java:144:in `callBlock'
    126	from CachingCallSite.java:153:in `callIter'
    127	from CallNoArgBlockNode.java:64:in `interpret'
    128	from NewlineNode.java:104:in `interpret'
    129	from RootNode.java:129:in `interpret'
    130	from ASTInterpreter.java:95:in `INTERPRET_EVAL'
    131	from ASTInterpreter.java:166:in `evalWithBinding'
    132	from RubyKernel.java:1126:in `evalCommon'
    133	from RubyKernel.java:1083:in `eval'
    134	from RubyKernel$s$0$3$eval.gen:65535:in `call'
    135	from DynamicMethod.java:227:in `call'
    136	from DynamicMethod.java:223:in `call'
    137	from CachingCallSite.java:235:in `call'
    138	from FCallThreeArgNode.java:40:in `interpret'
    139	from LocalAsgnNode.java:123:in `interpret'
    140	from NewlineNode.java:104:in `interpret'
    141	from BlockNode.java:71:in `interpret'
    142	from RescueNode.java:216:in `executeBody'
    143	from RescueNode.java:120:in `interpretWithJavaExceptions'
    144	from RescueNode.java:110:in `interpret'
    145	from BeginNode.java:83:in `interpret'
    146	from NewlineNode.java:104:in `interpret'
    147	from BlockNode.java:71:in `interpret'
    148	from ASTInterpreter.java:74:in `INTERPRET_METHOD'
    149	from InterpretedMethod.java:190:in `call'
    150	from DefaultMethod.java:199:in `call'
    151	from CachingCallSite.java:167:in `call'
    152	from CallOneArgNode.java:57:in `interpret'
    153	from DAsgnNode.java:110:in `interpret'
    154	from NewlineNode.java:104:in `interpret'
    155	from BlockNode.java:71:in `interpret'
    156	from ASTInterpreter.java:111:in `INTERPRET_BLOCK'
    157	from InterpretedBlock.java:374:in `evalBlockBody'
    158	from InterpretedBlock.java:347:in `yield'
    159	from InterpretedBlock.java:304:in `yield'
    160	from Block.java:130:in `yield'
    161	from RubyArray.java:1608:in `eachCommon'
    162	from RubyArray.java:1615:in `each'
    163	from RubyArray$i$0$0$each.gen:65535:in `call'
    164	from CachingCallSite.java:302:in `cacheAndCall'
    165	from CachingCallSite.java:144:in `callBlock'
    166	from CachingCallSite.java:153:in `callIter'
    167	from CallNoArgBlockNode.java:64:in `interpret'
    168	from NewlineNode.java:104:in `interpret'
    169	from ASTInterpreter.java:111:in `INTERPRET_BLOCK'
    170	from InterpretedBlock.java:374:in `evalBlockBody'
    171	from InterpretedBlock.java:347:in `yield'
    172	from InterpretedBlock.java:304:in `yield'
    173	from Block.java:130:in `yield'
    174	from RubyArray.java:1608:in `eachCommon'
    175	from RubyArray.java:1615:in `each'
    176	from RubyArray$i$0$0$each.gen:65535:in `call'
    177	from CachingCallSite.java:302:in `cacheAndCall'
    178	from CachingCallSite.java:144:in `callBlock'
    179	from CachingCallSite.java:153:in `callIter'
    180	from CallNoArgBlockNode.java:64:in `interpret'
    181	from NewlineNode.java:104:in `interpret'
    182	from BlockNode.java:71:in `interpret'
    183	from IfNode.java:119:in `interpret'
    184	from NewlineNode.java:104:in `interpret'
    185	from BlockNode.java:71:in `interpret'
    186	from ASTInterpreter.java:74:in `INTERPRET_METHOD'
    187	from InterpretedMethod.java:147:in `call'
    188	from DefaultMethod.java:183:in `call'
    189	from CachingCallSite.java:292:in `cacheAndCall'
    190	from CachingCallSite.java:135:in `call'
    191	from CallNoArgNode.java:63:in `interpret'
    192	from CallNoArgBlockNode.java:60:in `interpret'
    193	from NewlineNode.java:104:in `interpret'
    194	from BlockNode.java:71:in `interpret'
    195	from ASTInterpreter.java:74:in `INTERPRET_METHOD'
    196	from InterpretedMethod.java:169:in `call'
    197	from DefaultMethod.java:191:in `call'
    198	from RubyClass.java:552:in `finvoke'
    199	from RuntimeHelpers.java:529:in `invoke'
    200	from RubyEnumerable.java:93:in `callEach'
    201	from RubyEnumerable.java:650:in `selectCommon'
    202	from RubyEnumerable.java:672:in `find_all'
    203	from RubyEnumerable$s$0$0$find_all.gen:65535:in `call'
    204	from CachingCallSite.java:302:in `cacheAndCall'
    205	from CachingCallSite.java:144:in `callBlock'
    206	from CachingCallSite.java:153:in `callIter'
    207	from CallNoArgBlockNode.java:64:in `interpret'
    208	from LocalAsgnNode.java:123:in `interpret'
    209	from NewlineNode.java:104:in `interpret'
    210	from BlockNode.java:71:in `interpret'
    211	from ASTInterpreter.java:74:in `INTERPRET_METHOD'
    212	from InterpretedMethod.java:190:in `call'
    213	from DefaultMethod.java:199:in `call'
    214	from CachingCallSite.java:312:in `cacheAndCall'
    215	from CachingCallSite.java:169:in `call'
    216	from FCallOneArgNode.java:36:in `interpret'
    217	from LocalAsgnNode.java:123:in `interpret'
    218	from NewlineNode.java:104:in `interpret'
    219	from BlockNode.java:71:in `interpret'
    220	from ASTInterpreter.java:74:in `INTERPRET_METHOD'
    221	from InterpretedMethod.java:147:in `call'
    222	from DefaultMethod.java:183:in `call'
    223	from CachingCallSite.java:292:in `cacheAndCall'
    224	from CachingCallSite.java:135:in `call'
    225	from CallNoArgNode.java:63:in `interpret'
    226	from LocalAsgnNode.java:123:in `interpret'
    227	from NewlineNode.java:104:in `interpret'
    228	from BlockNode.java:71:in `interpret'
    229	from ASTInterpreter.java:74:in `INTERPRET_METHOD'
    230	from InterpretedMethod.java:147:in `call'
    231	from DefaultMethod.java:183:in `call'
    232	from CachingCallSite.java:292:in `cacheAndCall'
    233	from CachingCallSite.java:135:in `call'
    234	from CallNoArgNode.java:63:in `interpret'
    235	from LocalAsgnNode.java:123:in `interpret'
    236	from NewlineNode.java:104:in `interpret'
    237	from BlockNode.java:71:in `interpret'
    238	from ASTInterpreter.java:74:in `INTERPRET_METHOD'
    239	from InterpretedMethod.java:233:in `call'
    240	from DefaultMethod.java:215:in `call'
    241	from CachingCallSite.java:332:in `cacheAndCall'
    242	from CachingCallSite.java:203:in `call'
    243	from /home/vagrant/.rvm/gems/jruby-1.6.7.2@global/bin/bundle:22:in `__file__'
    244	from /home/vagrant/.rvm/gems/jruby-1.6.7.2@global/bin/bundle:-1:in `load'
    245	from Ruby.java:697:in `runScript'
    246	from Ruby.java:690:in `runScript'
    247	from Ruby.java:597:in `runNormally'
    248	from Ruby.java:446:in `runFromMain'
    249	from Main.java:369:in `doRunFromMain'
    250	from Main.java:258:in `internalRun'
    251	from Main.java:224:in `run'
    252	from Main.java:208:in `run'
    253	from Main.java:188:in `main'
    254
    255Done. Build script exited with: 1
Commits on Aug 12, 2012
Commits on Jul 26, 2012
  1. @begriffs

    remove debugging artifact

    Joe Nelson and Stephen Anderson committed with begriffs Jul 26, 2012
  2. @begriffs

    Fix :use_scenario_name behavior for cucumber scenario outlines

    Joe Nelson and Stephen Anderson committed with begriffs Jul 26, 2012
Commits on Jul 25, 2012
  1. Ignore rbx18-mode failures.

    committed Jul 25, 2012
    The travis build failed with no indication as to why:
    
    http://travis-ci.org/#!/myronmarston/vcr/jobs/1952677/L30
    
    ..and I've often had problems with the rbx build due to rbx issues.
  2. Merge pull request #184 from JonathanTron/patch-1

    committed Jul 25, 2012
    Typhoeus 0.4.2 is out and works fine with VCR
  3. @JonathanTron
Commits on Jul 20, 2012
  1. 2.2.4 release.

    committed Jul 19, 2012
  2. Update relish.

    committed Jul 19, 2012
    I got this message from relish just now:
    Sorry, your relish gem 0.5.3 is out of date. Please update to at least version 0.6
  3. Fix excon so real requests are made with a connection constructed wit…

    committed Jul 19, 2012
    …h same args.
    
    I got this warning from VCR on some tests using fog/excon to download a file from S3 over SSL:
    
    WARNING: VCR could not extract a response from Excon error (#<OpenSSL::SSL::SSLError: hostname does not match the server certificate>)
    
    I discovered that the SSL cert verification for a real request w/o VCR was made against
    `s3.amazonaws.com`, while the verification for the request being recorded by VCR was made
    against `<bucket_name>.s3.amazonaws.com`. The difference is due to the fact that fog
    constructs an Excon::Connection instance with a URI of `s3.amazonaws.com`, then makes a
    request with a :host param set to the FQDN. Before this commit, VCR made the real
    request by constructing a new Excon::Connection instance with the URI set to the full
    URI, and it caused the SSL cert verification failure.
    
    This fixes it by ensuring the "real request" connection instance is constructed with
    the same args as the original connection instance.
Commits on Jul 10, 2012
  1. 2.2.3 release.

    committed Jul 9, 2012
  2. Update RSpec.

    committed Jul 9, 2012
  3. No need for this global "seen request" tracking now that we're handli…

    committed Jul 9, 2012
    …ng Net::HTTP's recursion directly.
  4. Fix FakeWeb library hook for when a Net::HTTP request is re-used.

    committed Jul 3, 2012
    Previously I assumed a single Net::HTTP request object would only be used for a single
    request. It turns out it can trivially be re-used. I've refactored the implementation to
    no longer assume that. The request object was being used to hold a VCR request type
    object to handle internal recursion performed by Net::HTTP; now I have a special
    recursive request handler for this situation.
    
    Closes #178.
  5. @Jacobkg
  6. Fix typos in comments.

    committed Jul 6, 2012
Commits on Jun 27, 2012
Something went wrong with that request. Please try again.