Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-replay to 'Ports in other languages' #4

Closed
wants to merge 91 commits into from
Closed

Add node-replay to 'Ports in other languages' #4

wants to merge 91 commits into from

Conversation

@gavinhughes
Copy link

@gavinhughes gavinhughes commented Mar 3, 2013

No description provided.

plukevdh and others added 30 commits Nov 25, 2012
Add a built-in query string matcher
* typhoeus should work with all rubies
* add pry for debugging
Updated README links for new vcr location.
- Ensure effective_url is not nil
[ci skip]
myronmarston and others added 28 commits Jan 9, 2013
Documentation should prefer WebMock over Fakeweb
This ensures that the right version of simplecov
(and it's dependencies, like multi_json) get used.
Switch to new rspec expect syntax.
Fix fakeweb -> webmock failing cucumber tests
It's a bug in webmock (bblimke/webmock#246). This
spec will help prevent future regressions.

Closes vcr#245.
Fibers cannot be shared across threads, and you would get an error
when using this feature with threads:

FiberError: fiber called across threads

Actually, we were rescuing FiberError and transforming it into an even more confusing error:

Your around_http_request hook declared at <location> must call #proceed on the yielded request but did not.

Note that VCR is not thread safe (see vcr#200) but this brings it a bit closer.

Fixes vcr#257.
Fix issue with `around_http_request` when using multiple threads.
provided by aruba

update deps
Changes source from :rubygems to https://rubygems.org to remove warning.
@myronmarston
Copy link
Owner

@myronmarston myronmarston commented Mar 3, 2013

myronmarston/vcr is no longer the canonical git repo. vcr/vcr is.

I'd happily merge a PR like this if it was made against that repo.

(I'd only want the PR to have one commit though; I'm confused by the ton of commits shown here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet