Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

useless and incorrect super() generated #40

Closed
jmvanel opened this Issue · 7 comments

2 participants

@jmvanel

In this example, title is transmitted by calling the ancestor constructor in the main constructor of BagWindow :

class BagWindow(var bag: Bag[_], title: String)
extends NarsFrame(title) with ActionListener with AdjustmentListener {

but scalagen generates an useless and incorrect super() ( line 53 ) :
super(title)

The Java source:
https://open-nars.googlecode.com/svn/trunk/nars/gui/BagWindow.java

The generated Scala :
https://open-nars.googlecode.com/svn/trunk/nars_core/src/main/scala/nars/gui/BagWindow.scala

@timowest timowest referenced this issue from a commit
@timowest timowest #40 Add test c88f3e6
@timowest

Could you provide a self contained test case for this issue?

@jmvanel
@timowest

Yes, my test didn't reproduce the problem.

@jmvanel

About the GNU GPL problem, what if I simply provide the original Java source without licence, and a few names changed ?

@timowest

If you have the copyright for the code, you could do that.

@jmvanel

OK, you're right on this.
I don't want to bother Dr Pei Wang with this.

I perfectly understand that you want to stick to LGPL.
However, AFAIK, nothing prevents some GPL license code to be reused as input in testing another software.
The executable part of Scalagen will no code from NARS.

@timowest timowest referenced this issue from a commit
@timowest timowest #40 Add failing test case 3c8eea4
@timowest

Released in 0.2.2

@timowest timowest closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.