Skip to content

Commit

Permalink
Changed WITH_LEDS_BLINKING option to use the default LED pins as desc…
Browse files Browse the repository at this point in the history
…ribed on http://www.mysensors.org/build/advanced_gateway for consistency and backwards compatibility.  Also corrected the LED on/off state to HIGH/LOW from LOW/HIGH respectively.
  • Loading branch information
bblacey committed Jul 11, 2015
1 parent 616b7d8 commit 4abaa6d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
6 changes: 3 additions & 3 deletions libraries/MySensors/MyConfig.h
Expand Up @@ -58,11 +58,11 @@
// default LEDs blinking period in milliseconds
#define DEFAULT_LED_BLINK_PERIOD 300
// The RX LED default pin
#define DEFAULT_RX_LED_PIN 8
#define DEFAULT_RX_LED_PIN 6
// The TX LED default pin
#define DEFAULT_TX_LED_PIN 9
#define DEFAULT_TX_LED_PIN 5
// The Error LED default pin
#define DEFAULT_ERR_LED_PIN 7
#define DEFAULT_ERR_LED_PIN 4


/**********************************
Expand Down
18 changes: 9 additions & 9 deletions libraries/MySensors/MySensor.cpp
Expand Up @@ -110,33 +110,33 @@ void MySensor::handleLedsBlinking() {
// do the actual blinking
if(countRx && countRx != 255) {
// switch led on
digitalWrite(pinRx, LOW);
digitalWrite(pinRx, HIGH);
}
else if(!countRx) {
// switching off
digitalWrite(pinRx, HIGH);
digitalWrite(pinRx, LOW);
}
if(countRx != 255)
--countRx;

if(countTx && countTx != 255) {
// switch led on
digitalWrite(pinTx, LOW);
digitalWrite(pinTx, HIGH);
}
else if(!countTx) {
// switching off
digitalWrite(pinTx, HIGH);
digitalWrite(pinTx, LOW);
}
if(countTx != 255)
--countTx;

if(countErr && countErr != 255) {
// switch led on
digitalWrite(pinEr, LOW);
digitalWrite(pinEr, HIGH);
}
else if(!countErr) {
// switching off
digitalWrite(pinEr, HIGH);
digitalWrite(pinEr, LOW);
}
if(countErr != 255)
--countErr;
Expand Down Expand Up @@ -182,9 +182,9 @@ void MySensor::begin(void (*_msgCallback)(const MyMessage &), uint8_t _nodeId, b
pinMode(pinEr, OUTPUT);

// Set initial state of leds
digitalWrite(pinRx, HIGH);
digitalWrite(pinTx, HIGH);
digitalWrite(pinEr, HIGH);
digitalWrite(pinRx, LOW);
digitalWrite(pinTx, LOW);
digitalWrite(pinEr, LOW);

// initialize counters
countRx = 0;
Expand Down

0 comments on commit 4abaa6d

Please sign in to comment.