Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GatewayESP8266 and GatewayESP8266MQTTClient wiring #1096

Closed
mfalkvidd opened this Issue Mar 26, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@mfalkvidd
Copy link
Contributor

mfalkvidd commented Mar 26, 2018

The wiring instructions provided in comments in GatewayESP8266 and GatewayESP8266MQTTClient example sketches do not match the wiring instructions at https://www.mysensors.org/build/connect_radio

Suggestion: Remove the wiring instructions entirely from both sketches and point to https://www.mysensors.org/build/connect_radio only.

This discrepancy was reported by forum user RWoerz in https://forum.mysensors.org/topic/4800/building-a-wifi-gateway-using-esp8266/58

@mfalkvidd mfalkvidd self-assigned this Apr 2, 2018

mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue Apr 2, 2018

Remove faulty wiring instructions from ESP gateways
This fixes
mysensors#1096

Thanks to RWoerz for reporting this discrepancy.

@mfalkvidd mfalkvidd added the ESP8266 label Apr 2, 2018

@thucar

This comment has been minimized.

Copy link
Contributor

thucar commented Apr 3, 2018

I believe the wiring instructions in those examples should be carried over to the "Connecting the radio" page. The instructions are correct, but for a bare ESP8266 module whereas the current instructions on the Radio page are for the NodeMCU/Wemos boards.

I'm using mostly ESP8266-12E's on their own and I always find myself glancing at the wiring instructions in the examples to refresh my memory.

@mfalkvidd

This comment has been minimized.

Copy link
Contributor Author

mfalkvidd commented Apr 3, 2018

Thanks for the feedback on ESP-12E. I am not familiar with it, so I just left the comments in the sketch.
Now I've googled ESP-12E and I realized that I bought a few some time ago, but never got around to use them since the Wemos D1 mini is so much easier to use :-)

Just to make sure we're talking about the same instructions, these are the instructions I believe we're discussing:

 * Not all ESP8266 modules have all pins available on their external interface.
 * This code has been tested on an ESP-12 module.
 * The ESP8266 requires a certain pin configuration to download code, and another one to run code:
 * - Connect REST (reset) via 10K pullup resistor to VCC, and via switch to GND ('reset switch')
 * - Connect GPIO15 via 10K pulldown resistor to GND
 * - Connect CH_PD via 10K resistor to VCC
 * - Connect GPIO2 via 10K resistor to VCC
 * - Connect GPIO0 via 10K resistor to VCC, and via switch to GND ('bootload switch')

To me, adding these instructions to "connecting the radio" feels a bit weird, since none of the instructions concern the radio(s).

Would a new section at https://www.mysensors.org/build/esp8266_gateway be a good place?

mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue Apr 3, 2018

Remove faulty wiring instructions from ESP gateways
This fixes
mysensors#1096

https://www.mysensors.org/build/connect_radio
has been updated to include GPIOn instructions
(in addition to the existing Dn instructions).

Thanks to RWoerz for reporting this discrepancy.

Also, the "barebone" boot wiring has been moved to
http://bit.do/stupidurl

@mfalkvidd mfalkvidd closed this in d1aa419 Apr 7, 2018

fallberg added a commit that referenced this issue Jun 18, 2018

Remove faulty wiring instructions from ESP gateways (#1100)
This fixes
#1096

https://www.mysensors.org/build/connect_radio
has been updated to include GPIOn instructions
(in addition to the existing Dn instructions).

Thanks to RWoerz for reporting this discrepancy.

Also, the "barebone" boot wiring has been moved to
http://bit.do/stupidurl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.