Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI.h include missing for W5100 MQTT Ethernet Gateway #601

Closed
henrikekblad opened this issue Oct 5, 2016 · 7 comments

Comments

@henrikekblad
Copy link
Member

commented Oct 5, 2016

Removal of SPI.h (#555 )include might have killed the W5100 MQTT Gateway according to reports on the forum.

https://forum.mysensors.org/topic/4802/building-a-mqtt-gateway/8

Wondering why our Jenkins builds doesn't catch this.

@henrikekblad henrikekblad added the bug label Oct 5, 2016
@joshuacox

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2016

same here building the GatewaySerial

I'm betting we're both forgetting some configuration step that needs to be better documented as this was all working when I programmed a gateway a month ago, or perhaps this is something to do with 2.0?

In file included from /home/arduino/sketchbook/libraries/MySensors/drivers/RF24/RF24.cpp:23:0,
                 from /home/arduino/sketchbook/libraries/MySensors/MySensors.h:295,
                 from GatewaySerial.ino:86:
/home/arduino/sketchbook/libraries/MySensors/drivers/RF24/RF24.h:37:18: fatal error: SPI.h: No such file or directory
  #include <SPI.h>
                  ^
compilation terminated.

adding #include <SPI.h> only leads to further issues BTW

In file included from /home/arduino/sketchbook/libraries/MySensors/MySensors.h:130:0,
                 from GatewaySerial.ino:88:
/home/arduino/sketchbook/libraries/MySensors/core/MyInclusionMode.cpp: In function ‘void inclusionModeSet(bool)’:
/home/arduino/sketchbook/libraries/MySensors/core/MyInclusionMode.cpp:45:37: error: ‘hwMillis’ was not declared in this scope
      _inclusionStartTime = hwMillis();
                                     ^

EDIT: truncating the above error as it was due to me using an old version of the Arduino GUI, upgrading to 1.7.11 eliminated that issue, though the OP of SPI missing is still relevant

@henrikekblad

This comment has been minimized.

Copy link
Member Author

commented Oct 7, 2016

Which version of the IDE are you running? It actually compiles fine for 1.6.12 here.

@joshuacox

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2016

ya I realized it was an old version of the IDE, and corrected that, the SPI.h missing is still relevant though

@henrikekblad

This comment has been minimized.

Copy link
Member Author

commented Oct 7, 2016

What do you mean?
Are you still getting a compile error when not adding the SPI.h include?

@joshuacox

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2016

no I'm sorry, all good here, compiles fine once I add in the include, I only mean it is relevant as it should be fixed in the example code or whatever file needs that include

@joshuacox

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2016

scratch that too, after seeing your version (1.6.12) I tried the hourly build from arduino.cc and not arduino.org (where I got the 1.7.11 from) and everything works fine without the SPI.h include added gatewayserial. Sorry for the confusion.

@henrikekblad

This comment has been minimized.

Copy link
Member Author

commented Oct 7, 2016

Ok, thanks. Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.