Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP8266: DNS server #926

Open
Eagle2373 opened this issue Sep 11, 2017 · 6 comments
Open

ESP8266: DNS server #926

Eagle2373 opened this issue Sep 11, 2017 · 6 comments
Labels
enhancement ESP8266
Projects
2.4.0

Comments

@Eagle2373
Copy link

Currently it is not possible to specify the DNS server within MySensors and the ESP8266 falls back to the default DNS server (AFAIK opendns.com) as configured within the firmware.

The situation that I noticed is that opendns doesn't always resolve the domain name of my public webserver which I use to sent measure data to. By adding the DNS server in the WiFi.config call did resolve the issue for me. Could the DNS server be added as a #define and be added to the WiFi.config call?
@Eagle2373 Eagle2373 changed the title DNS serv DNS server Sep 11, 2017
@Eagle2373 Eagle2373 changed the title DNS server ESP8266: DNS server Sep 11, 2017
@mfalkvidd
Copy link
Member

If I'm reading the code correctly, MySensors will always use MY_IP_GATEWAY_ADDRESS as DNS server, if MY_IP_ADDRESS is defined.

The second parameter to WiFi-config is the dns server address according to https://www.arduino.cc/en/Reference/WiFiConfig

I'll add a pull request for this feature.

mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue Feb 18, 2018
@mfalkvidd
Add support for MY_DNS_ADDRESS
722d2cd 
When using static IP address of gateway,
MySensors used to use the home router as DNS server.

With this change, it is possible to define MY_DNS_ADDRESS
to be used as the DNS server instead.

Example code added to GatewayESP8266MQTTClient:
  #define MY_IP_ADDRESS 192,168,1,188
  #define MY_DNS_ADDRESS 9,9,9,9
  #define MY_IP_GATEWAY_ADDRESS 192,168,1,1
  #define MY_CONTROLLER_URL_ADDRESS "test.mosquitto.org"

However, the code does not seem to work yet, so consider this
a start and feel free to continue working on this or give
feedback.

This is an attempt to add the feature requested in mysensors#926
mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue Feb 18, 2018
@mfalkvidd
Add support for MY_DNS_ADDRESS
de6ee7d 
When using static IP address of gateway,
MySensors used to use the home router as DNS server.

With this change, it is possible to define MY_DNS_ADDRESS
to be used as the DNS server instead.

Example code added to GatewayESP8266MQTTClient:
  #define MY_IP_ADDRESS 192,168,1,188
  #define MY_DNS_ADDRESS 9,9,9,9
  #define MY_IP_GATEWAY_ADDRESS 192,168,1,1
  #define MY_CONTROLLER_URL_ADDRESS "test.mosquitto.org"

However, the code does not seem to work yet, so consider this
a start and feel free to continue working on this or give
feedback.

This is an attempt to add the feature requested in mysensors#926
mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue Feb 18, 2018
@mfalkvidd
Add support for MY_DNS_ADDRESS
e936d34 
When using static IP address of gateway,
MySensors used to use the home router as DNS server.

With this change, it is possible to define MY_DNS_ADDRESS
to be used as the DNS server instead.

Example code added to GatewayESP8266MQTTClient:
  #define MY_IP_ADDRESS 192,168,1,188
  #define MY_DNS_ADDRESS 9,9,9,9
  #define MY_IP_GATEWAY_ADDRESS 192,168,1,1
  #define MY_CONTROLLER_URL_ADDRESS "test.mosquitto.org"

However, the code does not seem to work yet, so consider this
a start and feel free to continue working on this or give
feedback.

This is an attempt to add the feature requested in mysensors#926
@mfalkvidd
Copy link
Member

Further test results. When using DHCP:

connected with Mr-IoT.com, channel 1
dhcp client start...
wifi evt: 0
ip:192.168.1.215,mask:255.255.255.0,gw:192.168.1.1
wifi evt: 3
6142 GWT:TPC:CONNECTING...
6144 GWT:TPC:IP=192.168.1.215
6147 MCO:BGN:STP
6148 MCO:REG:NOT NEEDED
6151 MCO:BGN:INIT OK,TSP=NA
6153 GWT:TPC:IP=192.168.1.215
6156 GWT:RMQ:MQTT RECONNECT
[hostByName] request IP for: test.mosquitto.org
[hostByName] Host: test.mosquitto.org IP: 37.187.106.16
6266 GWT:RMQ:MQTT CONNECTED
6269 GWT:TPS:TOPIC=mygateway1-out/0/255/0/0/17,MSG SENT

with static IP, regardless of setting MY_DNS_ADDRESS:

connected with Mr-IoT.com, channel 1
ip:192.168.1.188,mask:255.255.255.0,gw:192.168.1.1
ip:192.168.1.188,mask:255.255.255.0,gw:192.168.1.1
wifi evt: 0
wifi evt: 3
6138 GWT:TPC:CONNECTING...
6140 GWT:TPC:IP=192.168.1.188
6143 MCO:BGN:STP
6145 MCO:REG:NOT NEEDED
6147 MCO:BGN:INIT OK,TSP=NA
6149 GWT:TPC:IP=192.168.1.188
6152 GWT:RMQ:MQTT RECONNECT
[hostByName] request IP for: test.mosquitto.org
[hostByName] Host: test.mosquitto.org lookup error: -6!

So it seems dns resolution does not work at all when using static configuration. I will need to do more digging.
Above output was generated by setting "Debug level" to "Wifi" on the Tools menu in the Arduino IDE and setting "Debug port" to "serial".

@Eagle2373
Copy link
Author

Thx for picking this up. It's weird as I incorporated AFAIK the DNS in the WiFi.config call in MyGatewayTransportEthernet.cpp. The only thing is that I can't check it not earlier then coming weekend.
I sniffed a bit in the ESP8266 board code (version 2.3.0) and saw that in the file libraries/ESP8266Wifi/src/ESP8266WiFiSTA.h the following method declaration:
bool config(IPAddress local_ip, IPAddress gateway, IPAddress subnet, IPAddress dns1 = (uint32_t)0x00000000, IPAddress dns2 = (uint32_t)0x00000000);

Not sure how the compiler will resolve this if you provide a DNS address to the WiFi.config method...

@mfalkvidd
Copy link
Member

@Eagle2373 the ESp8266 config call uses some heuristics to reorder the parameters, since ESP8266 wifi config function uses a different order of parameters than the Arduino wifi config function. Reference: https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266WiFi/src/ESP8266WiFiSTA.h#L42

This makes it much harder to follow the code, which unfortunately has added a lot of troubleshooting time. My suspicion is that something goes wrong when trying to juggle around the parameters. I am not sure when I'll be able to pick this up again.

@fallberg fallberg added this to To do in 2.4.0 via automation Feb 25, 2018
mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue Mar 4, 2018
@mfalkvidd
Add support for MY_DNS_ADDRESS
d4c952b 
When using static IP address of gateway,
MySensors used to use the home router as DNS server.

With this change, it is possible to define MY_DNS_ADDRESS
to be used as the DNS server instead.

Example code added to GatewayESP8266MQTTClient:
  #define MY_IP_ADDRESS 192,168,1,188
  #define MY_DNS_ADDRESS 9,9,9,9
  #define MY_IP_GATEWAY_ADDRESS 192,168,1,1
  #define MY_CONTROLLER_URL_ADDRESS "test.mosquitto.org"

However, the code does not seem to work yet, so consider this
a start and feel free to continue working on this or give
feedback.

This is an attempt to add the feature requested in mysensors#926
mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue Mar 10, 2018
@mfalkvidd
Add support for MY_DNS_ADDRESS
43ea0a4 
When using static IP address of gateway,
MySensors used to use the home router as DNS server.

With this change, it is possible to define MY_DNS_ADDRESS
to be used as the DNS server instead.

Example code added to GatewayESP8266MQTTClient:
  #define MY_IP_ADDRESS 192,168,1,188
  #define MY_DNS_ADDRESS 9,9,9,9
  #define MY_IP_GATEWAY_ADDRESS 192,168,1,1
  #define MY_IP_SUBNET_ADDRESS 255,255,255,0
  #define MY_CONTROLLER_URL_ADDRESS "test.mosquitto.org"

This is an attempt to add the feature requested in mysensors#926

The code works, but definitely needs some cleanup.
I also need to add documentation for the DNS debug print.
@mfalkvidd
Copy link
Member

I got it working! Took a few hours, and I need to clean up the code, but it works:

connected with Mr-IoT.com, channel 1
ip:192.168.1.188,mask:255.255.255.0,gw:192.168.1.1
ip:192.168.1.188,mask:255.255.255.0,gw:192.168.1.1
wifi evt: 0
wifi evt: 3
6210 GWT:TPC:CONNECTING...
6238 GWT:TPC:IP=192.168.1.188
6270 GWT:TPC:DNS=9.9.9.9
6296 MCO:BGN:STP
6314 MCO:REG:NOT NEEDED
6339 MCO:BGN:INIT OK,TSP=NA
6369 GWT:TPC:IP=192.168.1.188
6400 GWT:TPC:DNS=9.9.9.9
6426 GWT:RMQ:MQTT RECONNECT
[hostByName] request IP for: test.mosquitto.org
[hostByName] Host: test.mosquitto.org IP: 37.187.106.16
:ref 1
:wr 25 25 0
:wrc 25 25 0
:sent 25
:rn 4
:c0 1, 4
6740 GWT:RMQ:MQTT CONNECTED
6797 GWT:TPS:TOPIC=mygateway1-out/0/255/0/0/17,MSG SENT

Code is available in my branch.

@mfalkvidd mfalkvidd self-assigned this Mar 10, 2018
mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue Mar 11, 2018
@mfalkvidd
Add support for MY_DNS_ADDRESS
79045df 
When using static IP address of gateway,
MySensors used to use the home router as DNS server.

With this change, it is possible to define MY_DNS_ADDRESS
to be used as the DNS server instead.

Example code added to GatewayESP8266MQTTClient:
  #define MY_IP_ADDRESS 192,168,1,188
  #define MY_DNS_ADDRESS 9,9,9,9
  #define MY_IP_GATEWAY_ADDRESS 192,168,1,1
  #define MY_IP_SUBNET_ADDRESS 255,255,255,0
  #define MY_CONTROLLER_URL_ADDRESS "test.mosquitto.org"

This is an attempt to add the feature requested in mysensors#926

The code works, but definitely needs some cleanup.
I also need to add documentation for the DNS debug print.
mfalkvidd added a commit to mfalkvidd/MySensors that referenced this issue Apr 14, 2018
@mfalkvidd
Add support for MY_DNS_ADDRESS
5e1b639 
When using static IP address of gateway,
MySensors used to use the home router as DNS server.

With this change, it is possible to define MY_DNS_ADDRESS
to be used as the DNS server instead.

Example code added to GatewayESP8266MQTTClient:
  #define MY_IP_ADDRESS 192,168,1,188
  #define MY_DNS_ADDRESS 9,9,9,9
  #define MY_IP_GATEWAY_ADDRESS 192,168,1,1
  #define MY_IP_SUBNET_ADDRESS 255,255,255,0
  #define MY_CONTROLLER_URL_ADDRESS "test.mosquitto.org"

This is an attempt to add the feature requested in mysensors#926

The code works, but definitely needs some cleanup.
I also need to add documentation for the DNS debug print.
@mfalkvidd
Copy link
Member

I am not able clean up the code. Tried a few times, but get stuck on the complexity. I'll leave my code in case someone else wants to try.

@mfalkvidd mfalkvidd removed their assignment May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ESP8266
Projects
2.4.0
  
To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mfalkvidd @henrikekblad @Eagle2373