Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow definition of MY_OTA_RETRY and MY_OTA_RETRY_DELAY #1241

Merged
merged 4 commits into from Jan 6, 2019

Conversation

pragtich
Copy link
Contributor

Hi there,

Playing with OTA firmware update, and struggling a bit because of the small number of retries and short retry delay. Essentially, a radio disturbance during 2.5s can lead to a failure of the OTA. This caused most uploads to fail in my situation.

Would you consider allowing the user to change MY_OTA_RETRY and/OR MY_OTA_RETRY_DELAY in order to influence their OTA process?

@mfalkvidd
Copy link
Member

It seems like #define FIRMWARE_MAX_REQUESTS (5u) is not used anywhere. Would you mind removing it?
Could you please add MY_OTA_RETRY and MY_OTA_RETRY_DELAY to
https://github.com/mysensors/MySensors/blob/development/keywords.txt ? This will make it easier for users to spot typos.

It seems like the doxygen documentation isn't being generated, but I think that is a general build problem, not related to this pull request.

@pragtich
Copy link
Contributor Author

pragtich commented Jan 6, 2019

FYI, I had an issue with failed checks due to a coding style problem (I had an indented #define).
The butler didn't manage to get an email to me: that made it a bit difficult to guess what was going on :-)

The PR should be good now...

@tekka007 tekka007 merged commit 1ee64f2 into mysensors:development Jan 6, 2019
@tekka007
Copy link
Contributor

tekka007 commented Jan 6, 2019

@pragtich thanks for your contribution!

@tekka007 tekka007 added this to To Do in 2.3.2 via automation Jan 6, 2019
@tekka007 tekka007 moved this from To Do to Done in 2.3.2 Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.3.2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants