Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present the gateway itself before gateway child sensors #420

Closed

Conversation

Projects
None yet
3 participants
@davidedmundson
Copy link

commented Apr 9, 2016

This fixes child nodes working under home-assistant

Present the gateway itself before gateway child sensors
This fixes child nodes working under home-assistant
@mysensors-jenkins

This comment has been minimized.

Copy link

commented Apr 9, 2016

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@henrikekblad

This comment has been minimized.

Copy link
Member

commented Apr 27, 2016

Could this be fixed in HomeAssistant instead? A bit worried how other controllers would react if we introduced this message.

@davidedmundson

This comment has been minimized.

Copy link
Author

commented Apr 27, 2016

Other controllers will need it too.

Gateways having child sensors is new.
Its mysensors "breaking" behavior by now having sensors without a presented sensor.

This patch brings the serial API to be the same as previous releases from the POV of the controller.

@henrikekblad

This comment has been minimized.

Copy link
Member

commented Apr 27, 2016

Hmm, true. It should probably be defined as a repeater anyhow. Could you update this?

@henrikekblad henrikekblad reopened this Apr 27, 2016

@mysensors-jenkins

This comment has been minimized.

Copy link

commented Apr 27, 2016

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@henrikekblad

This comment has been minimized.

Copy link
Member

commented Apr 27, 2016

When thinking a bit more it should probably be:

#if defined(MY_REPEATER_FEATURE)
   present(NODE_SENSOR_ID, S_ARDUINO_REPEATER);
#else
   present(NODE_SENSOR_ID, S_ARDUINO_NODE);
#endif

henrikekblad added a commit that referenced this pull request May 1, 2016

@henrikekblad

This comment has been minimized.

Copy link
Member

commented May 5, 2016

Fixed in #426

tbowmo pushed a commit to tbowmo/MySensors that referenced this pull request Jul 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.