New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signing presentation #740

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
3 participants
@tekka007
Contributor

tekka007 commented Jan 16, 2017

  • Fix signing presentation bug (introduced in #690)
  • skip signing of I_DISCOVER_REQUEST/RESPONSE messages

@tekka007 tekka007 added this to the 2.2.0 milestone Jan 16, 2017

@tekka007 tekka007 requested a review from fallberg Jan 16, 2017

@mysensors-jenkins

This comment has been minimized.

Show comment
Hide comment
@mysensors-jenkins

mysensors-jenkins Jan 16, 2017

Will evaluate git discipline...

mysensors-jenkins commented Jan 16, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Show comment
Hide comment
@mysensors-jenkins

mysensors-jenkins Jan 16, 2017

Git commit message(s) look good!

mysensors-jenkins commented Jan 16, 2017

Git commit message(s) look good!

@tekka007

This comment has been minimized.

Show comment
Hide comment
@tekka007

tekka007 Jan 16, 2017

Contributor

Jenkins, build examples please

Contributor

tekka007 commented Jan 16, 2017

Jenkins, build examples please

@mysensors-jenkins

This comment has been minimized.

Show comment
Hide comment
@mysensors-jenkins

mysensors-jenkins Jan 16, 2017

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoPR/641/

mysensors-jenkins commented Jan 16, 2017

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoPR/641/

@mysensors-jenkins

This comment has been minimized.

Show comment
Hide comment
@mysensors-jenkins

mysensors-jenkins Jan 16, 2017

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

mysensors-jenkins commented Jan 16, 2017

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@fallberg fallberg merged commit e669891 into mysensors:development Jan 16, 2017

4 checks passed

Gitler Git commit message(s) look good!
Details
Jenkins (examples) Examples built successfully.
Details
Jenkins (test sketches) Core tests successful.
Details
clahub All contributors have signed the Contributor License Agreement.
Details

@tekka007 tekka007 deleted the tekka007:SigningFix branch Jan 16, 2017

henrikekblad added a commit that referenced this pull request Jan 18, 2017

MySensors 2.1.1 release (#752)
* Bump version to 2.2.0-beta (#713)

* OTA: Add incoming FW block check (#718)

* Linux: Add support for SPIDEV (#734)

RPi and Linux refactor.

Add GPIO Sysfs for GPIO operations.

Update configure script.

Fix some cppcheck warnings.

Add serial emulation that prints to stdout.

Fix some file headers.

* Fix getControllerConfig() (#737)

* Rename MyHwATmega328 to MyHwAVR (#738)

* AVR: Restrict fast pin function use (#739)

* Fix signing presentation bug (#740)

* Consolidate open PRs for bugfix release (#741)

* Revert "Bump version to 2.2.0-beta" (#744)

* Merge Master into Dev (#745)

* Fix spi flash error when compiling in Arduino IDE 1.6.6

* Bump minor version

* Fixed "invalid suffix on literal" warning

* Fix addressing bug in _doSign bitfield

* Make sure nodes not supporting signing informs GW

A node that does not support signing, still needs to inform the
gateway about this to make sure the gateway carries a valid signing
requirement table when a node Id that was requiering signing stops
doing this.
This fixes #286.

* Prevent SecureActuator from accepting ACKs as commands

As ACKs are not currently signed, allowing ACKs as commands
is a considerable security hole for this sketch. This is now resolved.

* Backport of bugfix (#259) in repeaters when forwarding signed messages

* Bumped version to 1.5.2

* Corrected doSign variable name (was _doSign)

* Bumped version to 1.5.3

* Add NULL termination to payloads

Messages addressed to "this" node, will have a null char
appended to the payload after message verification is
done, because some "getters" assume the message being a
string.

* MySensors 2.1.1 release

@fallberg fallberg removed their request for review Nov 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment