Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MQTT Auth for RPi #756

Closed

Conversation

Projects
None yet
7 participants
@MichaelDanCurtis
Copy link

MichaelDanCurtis commented Jan 21, 2017

First time contributing, and still learning git,

These username and password options need to be added to allow users to configure a raspberry pi MQTT gateway.

Here is the "configure" file that has been corrected

Updated for MQTT on Raspberry PI with L/P
First time contributing, and still learning git,

These username and password options need to be added to allow users to configure a raspberry pi MQTT gateway.

Here is the "configure" file that has been corrected:
@mysensors-jenkins

This comment has been minimized.

Copy link

mysensors-jenkins commented Jan 21, 2017

Will evaluate git discipline...

@mysensors-jenkins

This comment has been minimized.

Copy link

mysensors-jenkins commented Jan 21, 2017

Git commit message(s) and/or coding style not good enough. I have mailed the details to the PR author.

@mysensors-jenkins

This comment has been minimized.

Copy link

mysensors-jenkins commented Jan 21, 2017

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@leothehuman
Copy link

leothehuman left a comment

Found these in the comments on the forum, realized that user/password authentication is already implemented in the code, just not available in ./configure script. This is exactly the pull request I would submit if it wasn't already here.
Please, help the author to get through the Gitler!

@MichaelDanCurtis MichaelDanCurtis changed the title Updated for MQTT on Raspberry PI with L/P Add MQTT Auth for RPi Jan 21, 2017

@marceloaqno

This comment has been minimized.

Copy link
Member

marceloaqno commented Jan 23, 2017

Jenkins, build examples please

@mysensors-jenkins

This comment has been minimized.

Copy link

mysensors-jenkins commented Jan 23, 2017

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoPR/648/

@stelgenhof

This comment has been minimized.

Copy link

stelgenhof commented Mar 21, 2017

Is there something stopping from merging this PR? Looking forward to this :)

@henrikekblad

This comment has been minimized.

Copy link
Member

henrikekblad commented Mar 21, 2017

Well, it seems to fail when the gitler checks the code. The last report has been wiped, so I can run the tests again.

Jenkins, build examples please.

@mysensors-jenkins

This comment has been minimized.

Copy link

mysensors-jenkins commented Mar 21, 2017

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoPR/670/

@tekka007

This comment has been minimized.

Copy link
Contributor

tekka007 commented Mar 21, 2017

Jenkins, build this please

@mysensors-jenkins

This comment has been minimized.

Copy link

mysensors-jenkins commented Mar 21, 2017

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

marceloaqno added a commit to marceloaqno/MySensors that referenced this pull request Mar 21, 2017

Linux: Configure script update
mysensors#756
- Documentation improvements.
- Fix bash warning.

henrikekblad added a commit that referenced this pull request Mar 21, 2017

Linux: Configure script update (#797)
Incorporates #756
- Documentation improvements.
- Fix bash warning.
@henrikekblad

This comment has been minimized.

Copy link
Member

henrikekblad commented Mar 21, 2017

Fixed in #797

@stelgenhof

This comment has been minimized.

Copy link

stelgenhof commented Mar 21, 2017

Thank you for this @henrikekblad !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.