Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use up to date strip_attributes gem instead of locally modified vendored plugin #903

Open
crowbot opened this issue Apr 2, 2013 · 3 comments

Comments

@crowbot
Copy link
Member

@crowbot crowbot commented Apr 2, 2013

Also get rid of special code to handle data that predates attribute stripping, and cleanup the data with a one-off script. Really the strip_attributes calls should be limited to attributes coming in from forms too, as stripping may well be unexpected in other fields that depend on trailing whitespace e.g. http://binarylogic.lighthouseapp.com/projects/18752/tickets/65-cant-update-attributes-on-newly-created-users

@mhl

This comment has been minimized.

Copy link
Contributor

@mhl mhl commented Aug 27, 2013

I've added a branch that switches to using the strip_attributes gem:

The problem with it is that we still need one of the changes (702399a) that @henare applied to our vendored version to fix its interaction with globalize3. We could fork the gem to make that change, but it would seem better in the long run if the patch could be introduced upstream. @henare, had you already tried that, or are you interested in doing so? (I see you'd made the pull request to get the allow_empty option that we need added, which is great :))

@henare

This comment has been minimized.

Copy link
Contributor

@henare henare commented Aug 27, 2013

Hmm, I can't see why I didn't submit it in the first place. It's in a branch at openaustralia/strip_attributes@209a6fc

I took a quick look and upstream's master has moved on a bit which would necessitate updating the patch a bit too.

@garethrees

This comment has been minimized.

Copy link
Member

@garethrees garethrees commented Aug 12, 2015

I've ported @henare's commits to the updated master https://github.com/mysociety/strip_attributes/tree/globalize3.

Need to add a spec to illustrate our issue.

garethrees added a commit that referenced this issue Aug 13, 2015
Use forked strip_attributes

Applies @henare's changes from 702399a.

See #903 for more info.
garethrees added a commit that referenced this issue Aug 13, 2015
Use forked strip_attributes

Applies @henare's changes from 702399a.

See #903 for more info.
garethrees added a commit that referenced this issue Aug 24, 2015
Applies @henare's changes from 702399a.

Upgrades from the deprecated bang syntax

See #903 for more info.
garethrees added a commit that referenced this issue Nov 17, 2015
Applies @henare's changes from 702399a.

Upgrades from the deprecated bang syntax

See #903 for more info.
garethrees added a commit that referenced this issue Nov 17, 2015
Applies @henare's changes from 702399a.

Upgrades from the deprecated bang syntax

See #903 for more info.
garethrees added a commit that referenced this issue Nov 17, 2015
Applies @henare's changes from 702399a.

Upgrades from the deprecated bang syntax

See #903 for more info.
@crowbot crowbot added the 0 - backlog label Sep 21, 2017
@garethrees garethrees added this to Backlog in mysociety/alaveteli May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.