Allow search for requests made to a tagged set of public authorities #3483

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@henare
Contributor

henare commented Sep 13, 2016

Creates a new search term request_public_body_tags so you can find requests that have been made to public bodies with certain tags.

Fixes #24.

henare added some commits Sep 13, 2016

Add integration test for tagged public body request search
This is an integration test for how searching for requests made to a
tagged set of public authorities could work.

See #24.
Add ability to search for requests made to tagged public bodies
In aea54a4 we copied the suggested way this search could work from #24
but in implementing it I realised that having
"tag:some_tag variety:sent" makes it ambiguous what the tag is on - the
request or the body?

So in this commit I've decided to create a new term for public body tags
on info_request_events in the same way that the tags from the
info_request is exposed.

To search for request with a particular public body tag, you use
"request_public_body_tag". It's a bit verbose but I think clarity is far
more important than brevity here.

Fixes #24.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 13, 2016

Coverage Status

Coverage increased (+0.07%) to 91.689% when pulling 94956d3 on openaustralia:24-search-requests-to-tagged-authorities into 7966aef on mysociety:develop.

Coverage Status

Coverage increased (+0.07%) to 91.689% when pulling 94956d3 on openaustralia:24-search-requests-to-tagged-authorities into 7966aef on mysociety:develop.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 13, 2016

Coverage Status

Coverage increased (+0.07%) to 91.689% when pulling 94956d3 on openaustralia:24-search-requests-to-tagged-authorities into 7966aef on mysociety:develop.

Coverage Status

Coverage increased (+0.07%) to 91.689% when pulling 94956d3 on openaustralia:24-search-requests-to-tagged-authorities into 7966aef on mysociety:develop.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 13, 2016

Coverage Status

Coverage decreased (-0.02%) to 91.595% when pulling 94956d3 on openaustralia:24-search-requests-to-tagged-authorities into 7966aef on mysociety:develop.

coveralls commented Sep 13, 2016

Coverage Status

Coverage decreased (-0.02%) to 91.595% when pulling 94956d3 on openaustralia:24-search-requests-to-tagged-authorities into 7966aef on mysociety:develop.

@henare henare referenced this pull request in openaustralia/righttoknow Sep 14, 2016

Closed

Research effectiveness of state and local requests #566

6 of 6 tasks complete

@garethrees garethrees self-assigned this Sep 15, 2016

@garethrees

This comment has been minimized.

Show comment
Hide comment
@garethrees

garethrees Sep 15, 2016

Member

Amazing, thanks! 🎉

Merged in 265087e.

Member

garethrees commented Sep 15, 2016

Amazing, thanks! 🎉

Merged in 265087e.

@garethrees garethrees closed this Sep 15, 2016

@henare henare deleted the openaustralia:24-search-requests-to-tagged-authorities branch Oct 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment