JS load all pages from user-tools list #257

Closed
supercooljames opened this Issue Feb 29, 2012 · 6 comments

Projects

None yet

3 participants

Collaborator

Matthew, do you need to sort the js call, or do we need to provide CSS/JS?

@dracos dracos was assigned Feb 29, 2012
Owner
dracos commented Mar 6, 2012

This exists for wards/updates on around, but creates independent scroll bar which we don't want, so needs looking at for that.

@joshangell joshangell pushed a commit that referenced this issue Mar 7, 2012
Josh Angell Change the behaviour of the js sliding in thing (for #257)
Should think about re-structuring the ajax call: perhaps adding a loading gif and then setting the global d_offset variable on success - it might all need moving around a bit though

Signed-off-by: Josh Angell <josh@supercooldesign.co.uk>
6c439ef
Collaborator

Finalised most of the behaviour, see commit: 083695a

Need to try and make the tools stick to the top/bottom on scroll when the drawer is open - js?

@joshangell joshangell pushed a commit that referenced this issue Mar 7, 2012
Josh Angell Add spiny ajax spinner thing to the ajax part of the drawer js functi…
…on (for #257)

Signed-off-by: Josh Angell <josh@supercooldesign.co.uk>
71eaea2
Owner
dracos commented Mar 8, 2012

Having played with this some more, I think having the report page have to scroll all the way to the bottom to show the small alerts box is disconcerting, and similarly for the wards when there are more than a few reports (e.g. when you close the drawer, you are no longer where you were). I think as the small alerts box is so small, its behaviour should be as previous, because there is no scrolling issue; and the others, as they are basically going always to be full height, should replace the main content, so that when they're closed the main content comes back where it was; does that make sense?

@joshangell joshangell added a commit that referenced this issue Mar 9, 2012
@joshangell joshangell For #257: make js load cover .content with new content if its big, ot…
…herwise display like a mini drawer
8742bca
Owner
dracos commented Mar 10, 2012

Related: b5f2bfd 8418a90 ac38521 ce86284 I'll close this now, the only other main thing in this area (going from a report to "More problems nearby" without page load) is separate and different, and will be quite tricky, so happy to leave for the time being.

@dracos dracos closed this Mar 10, 2012
Collaborator

Yeah the only thing I thought I might do was try and get rid of the flash from the tools bar on the full .content covering version.

Josh Angell

On 10 Mar 2012, at 01:16, Matthew Somervillereply@reply.github.com wrote:

Related: b5f2bfd 8418a90 ac38521 ce86284 I'll close this now, the only other main thing in this area (going from a report to "More problems nearby" without page load) is separate and different, and will be quite tricky, so happy to leave for the time being.


Reply to this email directly or view it on GitHub:
#257 (comment)

Collaborator

Ignore me, I just went and read through the commit log. Much better now you've refactored my mess!

Josh Angell

On 10 Mar 2012, at 01:16, Matthew Somervillereply@reply.github.com wrote:

Related: b5f2bfd 8418a90 ac38521 ce86284 I'll close this now, the only other main thing in this area (going from a report to "More problems nearby" without page load) is separate and different, and will be quite tricky, so happy to leave for the time being.


Reply to this email directly or view it on GitHub:
#257 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment