Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix template hierarchy #344

Open
dracos opened this Issue · 4 comments

3 participants

@dracos
Owner

The 'Default' cobrand uses the 'fixmystreet' template directory (in order to get the new design). This means some UK specific things (e.g. the help text in fixmystreet/questionnaire/completed-open.html) is part of the default cobrand. This should all be restructured so that the default cobrand is pretty design-less, 'oldstyle' is what is currently the design parts of the 'default' template directory, 'fixmystreet' is the design parts of the 'fixmystreet' template directory, and 'fixmystreet.com' (or whatever) has the UK specific things in it. I think.

@davewhiteland

I'll add my support to this issue because it's somewhat confusing to find elements from the fixmystreet web templates (e.g., the footer) appearing in a single-cobranded site (rather than the default ones), which is the common experience of a new (international) install.

I think #606 simplified the "make a new cobrand" aspect of customisation in a really helpful way, but this issue would also help because basically it would mean the default cobrand would indeed appear by default on a new cobrand, i.e., that's the expected behaviour.

@davewhiteland

Correction: I'm mistaken and that wouldn't happen. fixmystreet cobrand templates will still be used before default ones by default, to enage the new design.

@dracos
Owner

Call the design-less template directory "base" for clarity, if you want, so there is no "default" template directory, which is clearly causing confusion. Then a new cobrand, by default, would use the "fixmystreet" and "base" template directories. Someone could add their own template directory on top as all do for customisation. Or if they really wanted a radically different design, they could create their own cobrand directly on top of "base" instead. I think once any fixmystreet.com specific bits are reordered and pulled out, this will be clearer anyway.

@dracos dracos referenced this issue from a commit
@MyfanwyNixon MyfanwyNixon Update completed-open.html
Copy edits
8fa3401
@dracos
Owner

I'll leave this open, as a general push to consider whether things can be merged/removed from being in both base and fixmystreet. Now is probably a good time to move towards merging these more as warrants, whilst keeping an eye to making it easier to extend in general if you wanted a new design.

@dracos dracos referenced this issue from a commit
@dracos dracos Show logged in message as success, not error.
Fixes #357.
Also consolidate almost-identical fill_in_details.html template
(for #344).
e039f86
@dracos dracos referenced this issue from a commit
@dracos dracos Move tips/sidebar to separate templates.
Also apply to UK council cobrands. More food for #344.
eb8cc4b
@dracos dracos referenced this issue from a commit
@dracos dracos Move tips/sidebar to separate templates.
Also apply to UK council cobrands.
Fixes #926, more food for #344.
a8f45b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.