Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response template management #1500

Merged
merged 3 commits into from Sep 8, 2016
Merged

Conversation

davea
Copy link
Member

@davea davea commented Aug 24, 2016

This extends the Zürich response template admin functionality to all cobrands, and adds:

  • Templates have an 'auto-response' flag, for automatically adding an update when a problem is left (future functionality)
  • Templates can be assigned to individual categories in addition to bodies
  • Managing templates requires the template_edit permission.

For mysociety/fixmystreetforcouncils#31

@@ -254,6 +254,29 @@ sub has_permission_to {
return $permission ? 1 : undef;
}

=head2 has_body_permission_to
Copy link
Member

@dracos dracos Aug 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! I think there's probably a few other places this could be used.

@dracos
Copy link
Member

dracos commented Aug 26, 2016

Haven't had time to do in browser testing, but code review looks good :)

@davea davea force-pushed the issues/forcouncils/31-response-templates branch from 162119b to 4ae4721 Compare August 30, 2016 15:11
@dracos
Copy link
Member

dracos commented Sep 5, 2016

Still not had time to do in browser testing, but fixups also look good :) A grep for has_permission_to.*from_body shows other places that could use has_body_permission_to.

@dracos dracos added Reviewed and removed Reviewing labels Sep 5, 2016
@davea davea force-pushed the issues/forcouncils/31-response-templates branch 2 times, most recently from d857445 to f9b2ec7 Compare September 7, 2016 11:55
This builds on the response templates in the Zürich cobrand:

 - Allow response templates to be assigned to categories
 - Also adds a auto_response flag, which will be used to automatically create
    updates when reports are made.
 - Include response templates select box on update form

For mysociety/fixmystreetforcouncils#31
@davea davea force-pushed the issues/forcouncils/31-response-templates branch from f9b2ec7 to f6c8fa2 Compare September 8, 2016 08:46
@davea davea merged commit f6c8fa2 into master Sep 8, 2016
@davea davea removed the Reviewed label Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants