Assign users to categories #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A user can be assigned to any number of its body's categories - The category ids are stored as a list in the user's extra field
davea
force-pushed
the
issues/forcouncils/69-user-categories
branch
2 times, most recently
from
ffc090e
to
0af3e91
Compare
dracos
requested changes
Oct 28, 2016
| columns => [ 'category' ], | ||
| order_by => 'category', | ||
| })->all; | ||
| my $result = [ map( { $_->category } @categories ) ]; |
There was a problem hiding this comment.
You can probably use get_column here, something like my @categories = search({ id => …}, { order_by => 'category' })->get_column('category')->all; my $result = \@categories;
| %] | ||
| </p> | ||
| </div> | ||
| [% INCLUDE 'admin/category-checkboxes.html' %] |
| @@ -25,7 +25,7 @@ | |||
| %]span[% ELSE %]a href="[% base %]/my"[% END | |||
| %]>[% c.user_exists ? loc("Your account") : loc("Sign in") %]</[% c.req.uri.path == '/my' ? 'span' : 'a' %]></li>[% | |||
| %]<li><[% IF c.req.uri.path == '/reports' | |||
| %]span[% ELSE %]a href="[% base %]/reports"[% END | |||
| %]span[% ELSE %]a href="[% base %]/reports[% IF c.user_exists %]?filter_category=[% c.user.categories.join(",") | uri | html %][% END %]"[% END | |||
There was a problem hiding this comment.
As with the front page field you've added, do you want to only output this extra part of there are categories to include?
dracos
approved these changes
Oct 31, 2016
This pre-filters the 'all reports' link in the main nav and the /around page reached via the front page postcode form
davea
force-pushed
the
issues/forcouncils/69-user-categories
branch
from
675f550
to
15e9a1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left to do:
For mysociety/fixmystreetforcouncils#69