Disable questionnaires when closing/fixing reports via Open311

[davea]

Stops questionnaires being sent for reports closed/fixed via Open311.

Not sure if we want this behaviour for situations where a report has been closed/fixed by an admin/council staff user too?

Connects to https://github.com/mysociety/fixmystreet-freshdesk/issues/24.

Please check the following:

• Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
• Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog

[dracos]

Oh, I thought this was only for closed reports, I can't see us saying we'd do it for fixed ones? Fixed it makes more sense to still send it, I think, because in that case the questionnaire is reworded to ask if it truly is fixed, and gives the reporter the opportunity to reopen.

Yes, I don't see any reason not to make it apply to all closed reports, however made, in which case you can change Script/Questionnaire.pm to ignore closed_states (and/or mark them as sent) rather than do it at Open311 fetch time and have to spot any other place a state could be set?

[codecov]

Codecov Report

Merging #2310 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2310      +/-   ##
==========================================
+ Coverage   80.28%   80.28%   +<.01%     
==========================================
  Files         187      187              
  Lines       12082    12084       +2     
  Branches     2235     2236       +1     
==========================================
+ Hits         9700     9702       +2     
  Misses       1622     1622              
  Partials      760      760

Impacted Files	Coverage Δ
perllib/Open311/GetServiceRequestUpdates.pm	90.8% <100%> (+0.21%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20ccf5...b35ce07. Read the comment docs.

[davea]

All good points! I must have imagined the fixed requirement, sorry about that. Will force-push a much simpler change shortly.

[dracos]

👻