Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add Atom feeds for issues either by operator or map area #603

Merged
merged 11 commits into from Apr 16, 2012

Conversation

Projects
None yet
2 participants
Owner

mhl commented Apr 16, 2012

Add Atom feeds for issues either by operator or map area

These commits add in-page links to Atom feeds for issues in two situations:

  • When you're viewing the Issues tab of a particular Operator's page
  • When you're browsing issues in a particular area, i.e. when a map of issues is being shown

In the latter case the feed link will be updated dynamically when dragging the map or zooming in and out.

This pull request also includes commits with various other minor fixes.

mhl added some commits Apr 3, 2012

@mhl mhl Don't double-escape the title content in Atom feeds 8aaa281
@mhl mhl On dragging the issue map, update the URL with the new permalink
This relies on history.replaceState, which isn't supported on all
browsers.  However, if the history.replaceState function doesn't
exist, the behaviour will be as before.
9cca15d
@mhl mhl Reorder functions in map.js to avoid JSLint complaints 5de6f2c
@mhl mhl Fix many JSLint warnings
There are now only two JSLint errors if you use the following
options:

 {
   browser: true,
   'continue': true,
   'break': true,
   vars: true,
   white: true,
   plusplus: true,
   maxerr: 50,
   indent: 2
 }

The last two are (I think) spurious "strict violation" warnings
for:

  this.drawFeature(segment)

... in each case, I think because JSLint can't detect that
these functions are used as event handlers.
90a723a
@mhl mhl Fix a bug with map drawing if lat, lon and zoom are supplied in the URL 41319d1
@mhl mhl Include a " [FIXED]" suffix to titles of Atom entries where appropriate 62ceefe
@mhl mhl Add a partial to render an in-page link to an Atom feed a295966
@mhl mhl Add a per-operator Atom feed of issues, with an in-page link 588a7b3
@mhl mhl Add Atom feed (+ in-page link) for issues on the browse area page
This dynamically updates the link when scrolling the map
da81acd
@mhl mhl Use the name of the operator instead of "this operator" in the feed l…
…ink text
9011573
@mhl mhl Make it clearer that the link is for issues on and around the map f6ff288

@ghost ghost merged commit f6ff288 into mysociety:master Apr 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment