ZA - remove place filter on MP profiles list page #2237
Conversation
There was a problem hiding this comment.
The code change looks good, but I'm afraid I'm going to be a bit picky about the commit message. (Which I guess might not come as a crashing surprise ;))
Could you include in the commit message a brief explanation of why this is being done? Just linking to the issue (particularly just with an issue number, not a full URL) is not ideal - there's some justification for that here: http://mysociety.github.io/coding-standards.html#commit-messages
Also, I think it'd be worth adding a comment about how this removes the place filter from all position view pages, not just the MP profiles page? (To be clear, I'm OK with that - my feeling is that it's not very helpful on any of the pages - but I think it's worth a comment, since the commit subject currently suggests this a more specific change.)
|
(BTW, when I said it wasn't likely to be a surprise that I'm commenting on commit messages, that was alluding to the fact that I'm generally picky about them, nothing particular to you!) |
struan
force-pushed
the
2233-za-remove-search-dropdown
branch
from
b76ea8d
to
e6fbcc2
Compare
|
👍 Great, thanks! |
We're removing the place filter from search pages partly because the improved search makes it redundant and also because people mostly don't know which area to use so it's not actually very useful. Fixes #2233
struan
force-pushed
the
2233-za-remove-search-dropdown
branch
from
e6fbcc2
to
b7bbeee
Compare
This removes the dropdown for only showing MPs by area as it's largely been made redundant by the improved search.
Fixes #2233