Skip to content
This repository has been archived by the owner. It is now read-only.

Coalition display 500s #450

Closed
tmtmtmtm opened this issue May 9, 2014 · 3 comments · Fixed by #502

Comments

@tmtmtmtm
Copy link
Contributor

@tmtmtmtm tmtmtmtm commented May 9, 2014

http://eduskunta.popit.mysociety.org/organizations/popit.eduskunta/government/72 dies with:

Express
500 Error: Error rendering 'organization/view.html': Error: Error rendering 'membership/list-item.html': TypeError: Cannot read property 'url' of undefined
at Template.render (/data/vhost/popit.mysociety.org/popit/node_modules/underscore-template-additions/index.js:106:11)
at /data/vhost/popit.mysociety.org/popit/node_modules/underscore-template-additions/index.js:174:26
at Template.loadFromDir (/data/vhost/popit.mysociety.org/popit/node_modules/underscore-template-additions/index.js:27:12)
at View.engine (/data/vhost/popit.mysociety.org/popit/node_modules/underscore-template-additions/index.js:168:10)
at View.render (/data/vhost/popit.mysociety.org/popit/node_modules/express/lib/view.js:75:8)
at Function.app.render (/data/vhost/popit.mysociety.org/popit/node_modules/express/lib/application.js:500:10)
at ServerResponse.res.render (/data/vhost/popit.mysociety.org/popit/node_modules/express/lib/response.js:716:7)
at /data/vhost/popit.mysociety.org/popit/lib/apps/organization.js:46:11
at callbacks (/data/vhost/popit.mysociety.org/popit/node_modules/express/lib/router/index.js:160:37)
at /data/vhost/popit.mysociety.org/popit/node_modules/underscore/underscore.js:706:21
@chrismytton

This comment has been minimized.

Copy link
Member

@chrismytton chrismytton commented May 9, 2014

Ah yes, it looks like this line is causing the error because it's still handling memberships the old way.

@tmtmtmtm

This comment has been minimized.

Copy link
Contributor Author

@tmtmtmtm tmtmtmtm commented Jun 2, 2014

Any ETA on this being fixed? I hadn't been pushing for it much before, as I thought it was a page that was largely invisible unless you knew it was there (as there's no display for coalition memberships from a Party page), but I now realise that the links to "Government *" pages are quite prominent from http://eduskunta.popit.mysociety.org/organizations/ so it's very bad that they 500.

@chrismytton

This comment has been minimized.

Copy link
Member

@chrismytton chrismytton commented Jun 3, 2014

@tmtmtmtm This is the first thing in this weeks sprint, so I should be able to deploy a fix either later today or tomorrow :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.