New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track FB shares of voting record #1238

Closed
struan opened this Issue Mar 16, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@struan
Member

struan commented Mar 16, 2017

Because there isn't a Facebook event for sharing we'll need to roll our own share buttons for this and use Facebook's UI API to create the share dialog.

See http://stackoverflow.com/questions/19971888/capture-facebook-share-post-to-fb-event/19972058#19972058 for more details.

@struan struan self-assigned this Apr 11, 2017

@struan

This comment has been minimized.

Show comment
Hide comment

struan added a commit that referenced this issue Apr 12, 2017

custom Facebook share button for tracking MP voting record shares
It's not possible to subscribe to share events using FB.Event so roll
our own code to launch the share dialog using FB.ui. This means we can
hook in Google Analytics to the response handler.

Fixes #1238

@struan struan added the Reviewing label Apr 12, 2017

@struan struan closed this in #1253 Apr 19, 2017

@struan struan removed the Reviewing label Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment