Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using ms.loader.load to load javascript on Wikidata #134

Open
chrismytton opened this issue Jun 15, 2018 · 0 comments

Comments

@chrismytton
Copy link
Member

commented Jun 15, 2018

At the moment we're telling users to add an importScript line to their common.js on Wikidata, but this is deprecated in favour of mw.loader.load.

As an added bonus mw.loader.load allows you to load external scripts, so we could potentially load the script directly from the Rails app on Toolforge, though we'd have to remove the changing SHA from the generated JS path first. If we wanted to go this route we'd also have to investigate/fix #133.

screen shot 2018-06-15 at 16 10 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.