Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an alternative party image to be used #265

Open
andylolz opened this issue Mar 14, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@andylolz
Copy link
Collaborator

commented Mar 14, 2015

A candidate has requested the third party image here be used:
http://openelectoralcommission.org.uk/parties/PP804/trade-unionist-and-socialist-coalition/

Is this something for the party to resolve with the Electoral Commission? That is, does the order of the images hold some significance as far as the Electoral Commission are concerned?

Or, can this be resolved by reordering the images in Open Electoral Commission?

@mhl

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2015

We hardcode the image to use for some parties where the default is surprising when doing an import from OpenElectoralCommission: https://github.com/mysociety/yournextmp-popit/blob/master/candidates/management/commands/candidates_update_popit_parties_from_ec_data.py#L30-L41

Otherwise the first one in the OpenElectoralCommission list is used.

That's per-party, not per candidate, though. So at the moment, we could do the same for the TUSC if they all wanted that image used. I think ideally we would display the image that each candidate wants used on the ballot paper.

@andylolz

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 15, 2015

Perfect – thanks, Mark. I understood from the TUSC candidate that this would be for all candidates (since the third image is the logo they are using for this year’s campaign.) I’ve contacted the TUSC candidate to confirm this, though. If he confirms, I’ll send a PR.

mhl pushed a commit that referenced this issue May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.