Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong name the assembly #224

Closed
rabidkitten opened this issue Apr 3, 2017 · 4 comments
Closed

Strong name the assembly #224

rabidkitten opened this issue Apr 3, 2017 · 4 comments
Milestone

Comments

@rabidkitten
Copy link

rabidkitten commented Apr 3, 2017

I have included the MySqlConnector NuGet package in my .NET Core Project and once I signed my assembly, I could no longer build because MySqlConnector is not signed. Can we get this package signed?

@bgrainger
Copy link
Member

bgrainger commented Apr 3, 2017

Microsoft's Guidance:

For the most part, the majority of applications and libraries do not need strong-names.

Can you explain your use case that requires strong-naming?

@rabidkitten
Copy link
Author

rabidkitten commented Apr 3, 2017

I didn't realize that Microsoft had changed their position. When I run code analysis on a non-.NET Core solution inside of VS 2017, even today, I receive the warning CA2210 'Sign ... with a strong name key'. Of course, I continued this practice in my .NET Core solution and when adding your package, it being unsigned, resulted in the error above. It results in an error because I turned on Warnings as Errors to prevent developers from checking in code that has warnings (that haven't been addressed). But okay, I will actually unsign my assemblies as a result of the guidance they are providing now. It is interesting though they have not corrected Code Analysis.

@bgrainger
Copy link
Member

bgrainger commented Oct 23, 2017

As well as MiniProfiler, ServiceStack.OrmLite would need this dependency to be strong-named: ServiceStack/ServiceStack.OrmLite#602 (comment)

It seems like this will be an issue that potentially blocks more widespread adoption of MySqlConnector, so we should start strong-naming.

@bgrainger bgrainger reopened this Oct 23, 2017
@bgrainger bgrainger added this to the 1.0 milestone Oct 23, 2017
@bgrainger bgrainger changed the title MySqlConnector Version 0.15.1.0 Does Not Have A Strong Name Strong name the assembly Oct 23, 2017
bgrainger referenced this issue in MiniProfiler/dotnet Oct 31, 2017
This changeset moves core tests in MiniProfiler.Tests (StackExchange.Profiling.Tests) and MiniProfiler.Tests.AspNet.
- Table names are added to each of the DatabaseStorageBase classes which can now also create and drop their own schemas (extensions list in the tests project for safety). This allows flexibility to use whatever table names a user wants in normal operation as well as unique table names for testing.
- IAsyncStorage.SetUnviewedAfterSave has been removed, the provider (Redis and memory) are now directly responsible instead.
- MySql has moved to using the MySql.Data library instead of MySqlConnector, since MySqlConnector shows no signs on strong naming which we need.
- InternalsVisibleTo has been removed. RedisStorageHelpers is exposed in .Internal instead.
- xUnit upgraded to 2.3.0-beta5-build3769
- MiniProfilers.Providers.RavenDB.Tests removed (it wouldn't live here anyway if completed)
- IAsyncStorage testing is not unified in an abstract, so testing additional providers is very easy and adding a test adds a test for all.

Note: DbProfilerTests fails in netcoreapp1.1 only (data reader end event not firing), this may be a bug in .NET Core 1.1 or MiniProfiler...I need to dig a little and see.
Note 2: Sqlite skips loading various frameworks as well - need to see how many we can reliably test here. The Microsoft.Data.Sqlite vs. System.Data.Sqlite story is nuts.

Next: Need to add .AspNetCore test project and test both memory providers...along with everything else.

TL;DR: This is a major testing overhaul to greatly improve testing, coverage, and the ability to add new tests, new providers, and test new providers.
bgrainger added a commit to bgrainger/MySqlConnector that referenced this issue Oct 31, 2017
@bgrainger
Copy link
Member

bgrainger commented Oct 31, 2017

0.30.0 is strong-named.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants