Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in StatementPreparer #429

Closed
Atygayev opened this issue Jan 25, 2018 · 2 comments
Closed

bug in StatementPreparer #429

Atygayev opened this issue Jan 25, 2018 · 2 comments
Labels
bug
Milestone
1.0

Comments

@Atygayev
Copy link

If an sql statement has a comment it can be prepared wrongly, without passing parameters in it.
I have a unit test for reproducing the issue:
https://gist.github.com/anonymous/ee94694a0d3c617cc236bc479fdd399f
@bgrainger bgrainger added the bug label Jan 25, 2018
@bgrainger
Copy link
Member

Thanks for the test case; I can confirm this bug.

@bgrainger bgrainger added this to the 1.0 milestone Jan 25, 2018
bgrainger added a commit that referenced this issue Jan 27, 2018
@bgrainger
Fix error parsing -- comments in SQL. Fixes #429
8c844c9
@bgrainger
Copy link
Member

Fixed in 0.36.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
1.0
Development

No branches or pull requests
2 participants
@bgrainger @Atygayev