Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in StatementPreparer #429

Closed
Atygayev opened this issue Jan 25, 2018 · 2 comments
Closed

bug in StatementPreparer #429

Atygayev opened this issue Jan 25, 2018 · 2 comments
Labels
Milestone

Comments

@Atygayev
Copy link

@Atygayev Atygayev commented Jan 25, 2018

If an sql statement has a comment it can be prepared wrongly, without passing parameters in it.
I have a unit test for reproducing the issue:
https://gist.github.com/anonymous/ee94694a0d3c617cc236bc479fdd399f

@bgrainger bgrainger added the bug label Jan 25, 2018
@bgrainger
Copy link
Member

@bgrainger bgrainger commented Jan 25, 2018

Thanks for the test case; I can confirm this bug.

@bgrainger bgrainger added this to the 1.0 milestone Jan 25, 2018
@bgrainger
Copy link
Member

@bgrainger bgrainger commented Feb 16, 2018

Fixed in 0.36.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants