Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MySqlDateTime, AllowZeroDateTime #507

Closed
bgrainger opened this issue Jun 1, 2018 · 1 comment
Closed

Implement MySqlDateTime, AllowZeroDateTime #507

bgrainger opened this issue Jun 1, 2018 · 1 comment

Comments

@bgrainger
Copy link
Member

bgrainger commented Jun 1, 2018

The PeachPie project updated to MySqlConnector (peachpiecompiler/peachpie#209) but then reverted the change because AllowZeroDateTime isn't supported.

If this connection string option were supported, they might be able to adopt the library again. The documentation of the connection string setting is:

If set to True, MySqlDataReader.GetValue() returns a MySqlDateTime object for date or datetime columns that have disallowed values, such as zero datetime values, and a System.DateTime object for valid values. If set to False (the default setting) it causes a System.DateTime object to be returned for all valid values and an exception to be thrown for disallowed values, such as zero datetime values.

Implementing this may also fix #501.

@bgrainger
Copy link
Member Author

bgrainger commented Jun 2, 2018

PeachPie would also need PipeName #454 and InteractiveSession #510; just implementing AllowZeroDateTime isn't sufficient for their needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant