Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge Memory Consumption in Batch Insert/Updates in 0.42.2 #528

Closed
caleblloyd opened this issue Jul 6, 2018 · 3 comments
Closed

Huge Memory Consumption in Batch Insert/Updates in 0.42.2 #528

caleblloyd opened this issue Jul 6, 2018 · 3 comments
Assignees
Labels

Comments

@caleblloyd
Copy link
Contributor

@caleblloyd caleblloyd commented Jul 6, 2018

Upstream issue reported at PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#633

Insert/Update queries that use Batching in EF Core used to consume ~4MiB of memory are now consuming 2000-5000MiB of memory.

Mitigation was to downgrade from 0.42.2 to 0.42.1: PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#638

Possible root cause commits solely based on the version number are these 2:

@bgrainger
Copy link
Member

@bgrainger bgrainger commented Jul 6, 2018

The excess memory usage appears to be related to ResizableArray:

image

@bgrainger bgrainger self-assigned this Jul 6, 2018
@bgrainger bgrainger added the bug label Jul 6, 2018
@bgrainger
Copy link
Member

@bgrainger bgrainger commented Jul 6, 2018

@caleblloyd I'll ship a fix for this as soon as the Appveyor build stops having spurious failures.

bgrainger referenced this issue Jul 6, 2018
Before, any call to resize would always double the size of the array.
@bgrainger
Copy link
Member

@bgrainger bgrainger commented Jul 6, 2018

Fixed in 0.42.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants