New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CertificateStoreLocation and CertificateThumbprint in connection strings #536

Closed
hajekj opened this Issue Jul 26, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@hajekj
Copy link
Contributor

hajekj commented Jul 26, 2018

Since .NET Core can deal with Windows's certificate store, it should be supported in connection string just like in full .NET Framework versions.

@bgrainger

This comment has been minimized.

Copy link
Member

bgrainger commented Jul 26, 2018

Looks like the X509Store class is available in netstandard1.3 and higher.

hajekj added a commit to TheNetworg/MySqlConnector that referenced this issue Jul 26, 2018

@hajekj

This comment has been minimized.

Copy link
Contributor

hajekj commented Jul 26, 2018

I have started working on some basic implementation: https://github.com/TheNetworg/MySqlConnector will complete with tests and then submit a PR.

@hajekj

This comment has been minimized.

Copy link
Contributor

hajekj commented Jul 26, 2018

Okay, I have the initial code working now. I added some basic tests for connection string parsing, not sure how to approach the test against certificate store itself - should it attempt to write testing certificate to the store and then use that for tests? Or simply write the function requiring the input through InlineData? Eg. CertificateStoreLocation and the thumbprint?

hajekj added a commit to TheNetworg/MySqlConnector that referenced this issue Jul 26, 2018

Work on mysql-net#536
Signed-off-by: Jan Hajek <hajek.j@hotmail.com>

@bgrainger bgrainger closed this in e09c61f Jul 26, 2018

@hajekj

This comment has been minimized.

Copy link
Contributor

hajekj commented Jul 27, 2018

@bgrainger What is the release schedule for this package on Nuget? Do you think it would be possible to make a new release containing this change?

@bgrainger

This comment has been minimized.

Copy link
Member

bgrainger commented Jul 27, 2018

Added in 0.43.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment