Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can expose inner exception when occur MysqlException.CreateForTimeout? #575

Closed
kyohei0806 opened this issue Oct 25, 2018 · 3 comments
Closed

Can expose inner exception when occur MysqlException.CreateForTimeout? #575

kyohei0806 opened this issue Oct 25, 2018 · 3 comments
Assignees
@bgrainger
Labels
bug

Comments

@kyohei0806
Copy link

Hi, please see following line.

MySqlConnector/src/MySqlConnector/MySql.Data.MySqlClient/MySqlException.cs

Line 35 in 3619321

internal static MySqlException CreateForTimeout(Exception innerException) =>

Can this innerException contains to new instance of MySqlException?
Because, This code is running at my project.
I would detail of its inner-exception to investigate problem.
Thanks.
@bgrainger
Copy link
Member

This looks like an oversight when the code was added in e283475#diff-d50df248b8fcbea14a9c293a78bbff95R36; innerException should be getting passed to the new MySqlException.

@bgrainger bgrainger self-assigned this Oct 25, 2018
@bgrainger bgrainger added the bug label Oct 25, 2018
@kyohei0806
Copy link
Author

Thanks!!

@bgrainger bgrainger reopened this Oct 25, 2018
@bgrainger
Copy link
Member

Fixed in 0.46.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgrainger bgrainger

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bgrainger @kyohei0806