Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use IDbColumnSchemaGenerator from .NET 4.7.2 #595

Closed
bgrainger opened this issue Dec 10, 2018 · 1 comment
Closed

Can't use IDbColumnSchemaGenerator from .NET 4.7.2 #595

bgrainger opened this issue Dec 10, 2018 · 1 comment
Assignees

Comments

@bgrainger
Copy link
Member

@bgrainger bgrainger commented Dec 10, 2018

IDbColumnSchemaGenerator is available since .NET 4.7.1. However, if you install MySqlConnector into a .NET 4.7.2 project, it references the net461 library, which doesn't use that interface, rather than the netstandard2.0 library (which might be more appropriate).

We probably need to fix this by targeting net471 (which introduced the interface) for .NET Framework clients.

We should also check if any other new APIs are supported by net471 (and greater).

Finally, the #if check is wrong and blocks the API from netcoreapp2.1. Most likely, all #if checks should be rewritten to be negative, so that APIs are enabled by default.

@bgrainger bgrainger self-assigned this Dec 10, 2018
@bgrainger
Copy link
Member Author

@bgrainger bgrainger commented Dec 10, 2018

Fixed in 0.48.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant