There are cases when we check the data reader FieldCount property, in order to know if we should read the data reader. With the latest update, all these checks on the data reader are throwing exceptions, when the reader is empty and only output parameters are returned.
This breaks some of our property checks on the data reader, where until now no exception was expected.
Also, executing a query that, by its nature, does not return rows (such as a DELETE query), should set FieldCount to 0. What about the HasRows property?
(There are tests for FieldCount and HasRows for a "regular" empty MySqlDataReader, but not for the pseudo-empty one that represents a stored procedure with only output parameters.)
There are cases when we check the data reader FieldCount property, in order to know if we should read the data reader. With the latest update, all these checks on the data reader are throwing exceptions, when the reader is empty and only output parameters are returned.
This breaks some of our property checks on the data reader, where until now no exception was expected.
Also, executing a query that, by its nature, does not return rows (such as a DELETE query), should set FieldCount to 0. What about the HasRows property?
Originally posted by @kostebudinoski in #722 (comment)
The text was updated successfully, but these errors were encountered: