Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rows larger than 1 MiB in MySqlBulkCopy #834

Closed
bgrainger opened this issue Jun 16, 2020 · 0 comments
Closed

Allow rows larger than 1 MiB in MySqlBulkCopy #834

bgrainger opened this issue Jun 16, 2020 · 0 comments
Assignees

Comments

@bgrainger
Copy link
Member

@bgrainger bgrainger commented Jun 16, 2020

MySqlBulkCopy rents a fixed-size (1 MiB) buffer and requires that all rows fit entirely within the buffer.

Instead, large rows should be split across multiple payloads that are sent to the server. Keeping the buffer size at 1 MiB is probably fine unless performance testing shows that using larger buffers loads data more efficiently. (I'm not sure that increasing the size of the MySQL packets that are sent would speed things up; speed is probably more a function of the number of rows or type of data being inserted.)

This relaxes a limitation added by the fix for #780.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant