Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MySqlConnectionStringBuilder this[string] to return object #837

Closed
bgrainger opened this issue Jun 25, 2020 · 1 comment
Closed

Change MySqlConnectionStringBuilder this[string] to return object #837

bgrainger opened this issue Jun 25, 2020 · 1 comment
Milestone
1.0

Comments

@bgrainger
Copy link
Member

@bgrainger bgrainger commented Jun 25, 2020

MySqlConnectionStringBuilder should return object, not object?, from this[string keyword]. All reference properties should return non-null objects, e.g., an empty string instead of null.

Also add [AllowNull].

This is based on the most recent null-annotation proposal at https://github.com/dotnet/runtime/pull/689/files#diff-fbc8b4fa5b891e40cb60fd8fd075cc81R1964-R1965.
@bgrainger bgrainger added this to the 1.0 milestone Jun 25, 2020
@bgrainger bgrainger mentioned this issue Jun 25, 2020
Merged
@bgrainger
Copy link
Member Author

@bgrainger bgrainger commented Jun 26, 2020

Fixed in 1.0.0-beta.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@bgrainger