Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DisposeAsync fully async in failure case #876

Closed
bgrainger opened this issue Aug 19, 2020 · 0 comments · Fixed by #892
Closed

Make DisposeAsync fully async in failure case #876

bgrainger opened this issue Aug 19, 2020 · 0 comments · Fixed by #892

Comments

@bgrainger
Copy link
Member

From #872 (comment):

The following call stack is possible:

MySqlConnection.DisposeAsync
MySqlConnection.CloseAsync
ServerSession.ReturnToPool
ConnectionPool.Return
ServerSession.DisposeAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();

The two non-Async methods eventually cause sync-over-async in the failure path.

dlemstra added a commit to dlemstra/MySqlConnector that referenced this issue Oct 4, 2020
dlemstra added a commit to dlemstra/MySqlConnector that referenced this issue Oct 4, 2020
Signed-off-by: Dirk Lemstra <dirk@lemstra.org>
bgrainger added a commit that referenced this issue Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant